From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: "Joshi, Sreedevi" <sreedevi.joshi@intel.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Loktionov, Aleksandr" <aleksandr.loktionov@intel.com>,
"Samudrala, Sridhar" <sridhar.samudrala@intel.com>,
"Tantilov, Emil S" <emil.s.tantilov@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net 2/3] idpf: Fix RSS LUT configuration on down interfaces
Date: Fri, 21 Nov 2025 14:36:46 -0800 [thread overview]
Message-ID: <62207dc3-3deb-43c1-a895-53fe01bf20bd@intel.com> (raw)
In-Reply-To: <IA1PR11MB628988BEDBE721E28252D46D89D5A@IA1PR11MB6289.namprd11.prod.outlook.com>
On 11/21/2025 1:53 PM, Joshi, Sreedevi wrote:
...
>>> @@ -393,7 +393,10 @@ static u32 idpf_get_rxfh_indir_size(struct net_device *netdev)
>>> * @netdev: network interface device structure
>>> * @rxfh: pointer to param struct (indir, key, hfunc)
>>> *
>>> - * Reads the indirection table directly from the hardware. Always returns 0.
>>> + * RSS LUT and Key information are read from driver's cached
>>> + * copy. When rxhash is off, rss lut will be displayed as zeros.
>>> + *
>>> + * Returns 0 on success.
>>
>> Can you make this Return: to make kdoc happy?
> Will do.
> BTW, looks like there are other occurrences of this in that file.
Yea, much of this file was committed before that check was put in
place/enforced so there are many occurrences of this in the file :( We
don't want to introduce any new violations though.
Thanks,
Tony
next prev parent reply other threads:[~2025-11-21 22:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 4:22 [Intel-wired-lan] [PATCH iwl-net 0/3] idpf: Fix issues in rxhash and rss lut logic Sreedevi Joshi
2025-11-18 4:22 ` [Intel-wired-lan] [PATCH iwl-net 1/3] idpf: Fix RSS LUT NULL pointer crash on early ethtool operations Sreedevi Joshi
2025-11-18 7:22 ` Paul Menzel
2025-11-18 19:20 ` Joshi, Sreedevi
2025-11-21 21:22 ` Tony Nguyen
2025-11-22 5:03 ` Joshi, Sreedevi
2025-11-18 4:22 ` [Intel-wired-lan] [PATCH iwl-net 2/3] idpf: Fix RSS LUT configuration on down interfaces Sreedevi Joshi
2025-11-21 21:27 ` Tony Nguyen
2025-11-21 21:53 ` Joshi, Sreedevi
2025-11-21 22:36 ` Tony Nguyen [this message]
2025-11-18 4:22 ` [Intel-wired-lan] [PATCH iwl-net 3/3] idpf: Fix RSS LUT NULL ptr issue after soft reset Sreedevi Joshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62207dc3-3deb-43c1-a895-53fe01bf20bd@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=aleksandr.loktionov@intel.com \
--cc=emil.s.tantilov@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=netdev@vger.kernel.org \
--cc=sreedevi.joshi@intel.com \
--cc=sridhar.samudrala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox