From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Jun Zhang <xuejun.zhang@intel.com>, <intel-wired-lan@lists.osuosl.org>
Cc: Przemyslaw Patynowski <przemyslawx.patynowski@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH net v2] iavf: Disallow changing rx/tx-frames and rx/tx-frames-irq
Date: Fri, 10 Jun 2022 10:32:28 -0700 [thread overview]
Message-ID: <634f4d1c-301e-26ec-1772-fa8568c4c6ff@intel.com> (raw)
In-Reply-To: <20220609220121.1286133-1-xuejun.zhang@intel.com>
On 6/9/2022 3:01 PM, Jun Zhang wrote:
> From: Przemyslaw Patynowski <przemyslawx.patynowski@intel.com>
>
> Remove support for rx/tx-frames and rx/tx-frames-irq as it is
> introducing counterintuitive settings and is not stated in any
> requirement.
I suggest remove the requirements portion; this doesn't really apply to
the kernel.
> Remove from supported_coalesce_params ETHTOOL_COALESCE_MAX_FRAMES
> and ETHTOOL_COALESCE_MAX_FRAMES_IRQ. As tx-frames-irq allowed
> user to change budget for iavf_clean_tx_irq, remove work_limit
> and use define for budget.
> Without this patch there would be possiblity to change rx/tx-frames
> and rx/tx-frames-irq, which for rx/tx-frames did nothing, while for
> rx/tx-frames-irq it changed rx/tx-frames and only changed budget
> for cleaning NAPI poll.
>
I missed this on v1, but where is the Fixes tag? All net bug fixes need one.
> Signed-off-by: Przemyslaw Patynowski <przemyslawx.patynowski@intel.com>
> Signed-off-by: Jun Zhang <xuejun.zhang@intel.com>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
prev parent reply other threads:[~2022-06-10 17:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 22:01 [Intel-wired-lan] [PATCH net v2] iavf: Disallow changing rx/tx-frames and rx/tx-frames-irq Jun Zhang
2022-06-10 17:32 ` Tony Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=634f4d1c-301e-26ec-1772-fa8568c4c6ff@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=przemyslawx.patynowski@intel.com \
--cc=xuejun.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox