From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Jedrzej Jagielski <jedrzej.jagielski@intel.com>,
<intel-wired-lan@lists.osuosl.org>
Subject: Re: [Intel-wired-lan] [PATCH net v3] iavf: Do not modify queue number when removing iavf driver
Date: Wed, 8 Jun 2022 16:31:01 -0700 [thread overview]
Message-ID: <63b60a2a-a374-7e4f-2eaf-6bed67703f67@intel.com> (raw)
In-Reply-To: <20220608095337.2986633-1-jedrzej.jagielski@intel.com>
On 6/8/2022 2:53 AM, Jedrzej Jagielski wrote:
> From: Grzegorz Szczurek <grzegorzx.szczurek@intel.com>
>
> If VF has configured tc qdisc with number of queues less than original
> set and then the driver went in removing process, tc resources are also
> releasing. Attempt of modify real num tx/rx in this state is causing
> call trace, because kernel is trying to release uninitialized queues
>
> Fix it by not modifying the number of queues when removing a driver
<snip>
> --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
> @@ -3471,6 +3471,9 @@ static int __iavf_setup_tc(struct net_device *netdev, void *type_data)
> }
> }
> exit:
> + if (test_bit(__IAVF_IN_REMOVE_TASK, &adapter->crit_section))
> + return 0;
> +
> return ret;
How is this not modifying the number of queues? From what I can tell,
this returning success if we are in remove.
> }
>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
prev parent reply other threads:[~2022-06-08 23:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 9:53 [Intel-wired-lan] [PATCH net v3] iavf: Do not modify queue number when removing iavf driver Jedrzej Jagielski
2022-06-08 23:31 ` Tony Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63b60a2a-a374-7e4f-2eaf-6bed67703f67@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jedrzej.jagielski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox