From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Dan Carpenter <error27@gmail.com>, <oe-kbuild@lists.linux.dev>,
"Paul M Stillwell Jr" <paul.m.stillwell.jr@intel.com>
Cc: Intel Wired LAN <intel-wired-lan@lists.osuosl.org>,
oe-kbuild-all@lists.linux.dev
Subject: Re: [Intel-wired-lan] [tnguy-net-queue:dev-queue 2/17] drivers/net/ethernet/intel/ice/ice_main.c:4921 ice_probe() warn: missing error code 'err'
Date: Thu, 29 Dec 2022 14:27:41 -0800 [thread overview]
Message-ID: <67374aba-998f-b14c-d785-82ed8fa9bca5@intel.com> (raw)
In-Reply-To: <202212291532.mOisbpke-lkp@intel.com>
On 12/29/2022 12:58 AM, Dan Carpenter wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue.git dev-queue
> head: c342bc11f5a438cf39e2280bafda39ec2c6953f1
> commit: e51d0e34580892d22107a85390d1752fa7a7d56a [2/17] ice: move devlink port creation/deletion
> config: powerpc-randconfig-m031-20221226
> compiler: powerpc-linux-gcc (GCC) 12.1.0
>
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
> | Reported-by: Dan Carpenter <error27@gmail.com>
>
> smatch warnings:
> drivers/net/ethernet/intel/ice/ice_main.c:4921 ice_probe() warn: missing error code 'err'
>
> vim +/err +4921 drivers/net/ethernet/intel/ice/ice_main.c
>
> df006dd4b1dca8 Dave Ertman 2020-11-20 4908 if (ice_init_lag(pf))
> df006dd4b1dca8 Dave Ertman 2020-11-20 4909 dev_warn(dev, "Failed to init link aggregation support\n");
> df006dd4b1dca8 Dave Ertman 2020-11-20 4910
> e18ff118181bca Paul Greenwalt 2019-10-09 4911 /* print PCI link speed and width */
> e18ff118181bca Paul Greenwalt 2019-10-09 4912 pcie_print_link_status(pf->pdev);
> e18ff118181bca Paul Greenwalt 2019-10-09 4913
> de75135b5c04c9 Anirudh Venkataramanan 2020-05-07 4914 probe_done:
> e51d0e34580892 Paul M Stillwell Jr 2022-11-18 4915 err = ice_devlink_create_pf_port(pf);
> e51d0e34580892 Paul M Stillwell Jr 2022-11-18 4916 if (err)
> e51d0e34580892 Paul M Stillwell Jr 2022-11-18 4917 goto err_create_pf_port;
> e51d0e34580892 Paul M Stillwell Jr 2022-11-18 4918
> e51d0e34580892 Paul M Stillwell Jr 2022-11-18 4919 vsi = ice_get_main_vsi(pf);
> e51d0e34580892 Paul M Stillwell Jr 2022-11-18 4920 if (!vsi || !vsi->netdev)
> e51d0e34580892 Paul M Stillwell Jr 2022-11-18 @4921 goto err_netdev_reg;
>
> This seems like an error path so "err = -EINVAL;"
Thanks for the report Dan. We'll get this fixed.
Thanks,
Tony
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
prev parent reply other threads:[~2022-12-29 22:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-29 8:58 [Intel-wired-lan] [tnguy-net-queue:dev-queue 2/17] drivers/net/ethernet/intel/ice/ice_main.c:4921 ice_probe() warn: missing error code 'err' Dan Carpenter
2022-12-29 22:27 ` Tony Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67374aba-998f-b14c-d785-82ed8fa9bca5@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=error27@gmail.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=paul.m.stillwell.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox