From: Brett Creeley <bcreeley@amd.com>
To: Lukasz Plachno <lukasz.plachno@intel.com>,
intel-wired-lan@lists.osuosl.org
Cc: Przemek Kitszel <przemyslaw.kitszel@intel.com>,
netdev@vger.kernel.org,
Jakub Buchocki <jakubx.buchocki@intel.com>,
Mateusz Pacuszka <mateuszx.pacuszka@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v3 2/2] ice: Implement 'flow-type ether' rules
Date: Tue, 19 Dec 2023 09:35:32 -0800 [thread overview]
Message-ID: <693fb63e-8369-9cf7-4b41-7afc00b30618@amd.com> (raw)
In-Reply-To: <20231214043449.15835-3-lukasz.plachno@intel.com>
On 12/13/2023 8:34 PM, Lukasz Plachno wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> From: Jakub Buchocki <jakubx.buchocki@intel.com>
>
> Add support for 'flow-type ether' Flow Director rules via ethtool.
>
> Rules not containing masks are processed by the Flow Director,
> and support the following set of input parameters in all combinations:
> src, dst, proto, vlan-etype, vlan, action.
>
> It is possible to specify address mask in ethtool parameters but only
> 00:00:00:00:00 and FF:FF:FF:FF:FF are valid.
> The same applies to proto, vlan-etype and vlan masks:
> only 0x0000 and 0xffff masks are valid.
Would it be useful to have user facing error messages for invalid masks
stating what the valid masks are?
>
> Signed-off-by: Jakub Buchocki <jakubx.buchocki@intel.com>
> Co-developed-by: Mateusz Pacuszka <mateuszx.pacuszka@intel.com>
> Signed-off-by: Mateusz Pacuszka <mateuszx.pacuszka@intel.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Signed-off-by: Lukasz Plachno <lukasz.plachno@intel.com>
> ---
> .../net/ethernet/intel/ice/ice_ethtool_fdir.c | 128 +++++++++++++++++-
> drivers/net/ethernet/intel/ice/ice_fdir.c | 27 ++++
> drivers/net/ethernet/intel/ice/ice_fdir.h | 11 ++
> drivers/net/ethernet/intel/ice/ice_type.h | 1 +
> 4 files changed, 166 insertions(+), 1 deletion(-)
>
[...]
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-12-19 17:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 4:34 [Intel-wired-lan] [PATCH iwl-next v3 0/2] ice: Support flow director ether type filters Lukasz Plachno
2023-12-14 4:34 ` [Intel-wired-lan] [PATCH iwl-next v3 1/2] ice: Remove unnecessary argument from ice_fdir_comp_rules() Lukasz Plachno
2023-12-16 10:04 ` Simon Horman
2023-12-14 4:34 ` [Intel-wired-lan] [PATCH iwl-next v3 2/2] ice: Implement 'flow-type ether' rules Lukasz Plachno
2023-12-16 10:03 ` Simon Horman
2023-12-19 14:04 ` Plachno, Lukasz
2023-12-19 17:35 ` Brett Creeley [this message]
2023-12-20 14:19 ` Plachno, Lukasz
2023-12-20 17:11 ` Brett Creeley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=693fb63e-8369-9cf7-4b41-7afc00b30618@amd.com \
--to=bcreeley@amd.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jakubx.buchocki@intel.com \
--cc=lukasz.plachno@intel.com \
--cc=mateuszx.pacuszka@intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox