From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD04CC4167B for ; Mon, 4 Dec 2023 21:32:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 3B69640151; Mon, 4 Dec 2023 21:32:35 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 3B69640151 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1701725555; bh=CJB3DYj9p/ddSL/C4ZRczjTMFiQvSOoU0L+mMJ/TLWA=; h=From:To:Date:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=LU8QYQW0iCc6ckWk8fLm+7w/39MTae84YE7XdQck87ey0Lwx6OJTAx5warFRrFIP/ CHk1JBPrysy7sJrx0GIlZImjOtMwWnJG0qhqB6ZR2JmCarQbvUAF6ZI1PHxms9S0Er EFIr9FWRXM34/gLyFqWAAWEO25O+xb2G7xROx9CKy4UNH2ZgGIN3rcA2S24C7FdnUQ VoarYEl8ZoAGSLRGRMQ2JttHLTnom5uhGTPj2PsJDkR4oQODsThyMgnL6xkrJay11b zVGWGtbDq8DGinH74keRveEWyHSKrx2EyjR/9X/lRnOpcP9FsN7xfrpfZwQ+tRI2m5 kIJm67kaOC3/Q== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rv8Ql8B6Z-6O; Mon, 4 Dec 2023 21:32:34 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id DF9C240201; Mon, 4 Dec 2023 21:32:33 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org DF9C240201 Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 216721BF30E for ; Mon, 4 Dec 2023 21:32:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 0135841795 for ; Mon, 4 Dec 2023 21:32:32 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 0135841795 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jm3WtwzCTqYU for ; Mon, 4 Dec 2023 21:32:31 +0000 (UTC) Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:242:246e::2]) by smtp4.osuosl.org (Postfix) with ESMTPS id 293FF41793 for ; Mon, 4 Dec 2023 21:32:31 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 293FF41793 Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.97) (envelope-from ) id 1rAGYE-0000000FGpo-1Fro; Mon, 04 Dec 2023 22:32:26 +0100 Message-ID: <69c0fa67c2b0930f72e99c19c72fc706627989af.camel@sipsolutions.net> From: Johannes Berg To: Marc MERLIN Date: Mon, 04 Dec 2023 22:32:25 +0100 In-Reply-To: <20231204212849.GA25864@merlins.org> References: <20231204200710.40c291e60cea.I2deb5804ef1739a2af307283d320ef7d82456494@changeid> <20231204200038.GA9330@merlins.org> <20231204203622.GB9330@merlins.org> <24577c9b8b4d398fe34bd756354c33b80cf67720.camel@sipsolutions.net> <20231204205439.GA32680@merlins.org> <20231204212849.GA25864@merlins.org> User-Agent: Evolution 3.50.1 (3.50.1-1.fc39) MIME-Version: 1.0 X-malware-bazaar: not-scanned X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=7JmWiw2OjGew/L9t8WojbOOKVqJKnGxbMVBwCRVjGDA=; t=1701725551; x=1702935151; b=mChIJu57D94WwqsN5YKWbezoTd6ZadBf3AYYNRZS3wWluK1 XOyviJek5AAH+OoMlpPbbLT0Z2jKNJ0jb07H0kuTG598rk6jEYFbie9mcMemWjUN4icBwIcT/+Wu4 3L4L7JpkJklwOQ2CBn4Z11ttvNwnGtpMKQbNX2UVMLuy/JBPiyRQTmzMJCjZeVb9o05Fr6BmgFWfI TCW+hzVmasHpoxfBZsNkISt9r+OtOH04LL+A5rd+906VKRgU/x6fSSggeTUQEC1hUMPj8DLqeIpxb ZyqbNiJANnUQDXmD+XJXL4FVu74t0rcRltS4gQCYmqT+e8yp7zMKIfXK3QAK34Vg==; X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.a=rsa-sha256 header.s=mail header.b=mChIJu57 Subject: Re: [Intel-wired-lan] [RFC PATCH] net: ethtool: do runtime PM outside RTNL X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, Jesse Brandeburg , intel-wired-lan@lists.osuosl.org, Jakub Kicinski , Tony Nguyen , Heiner Kallweit Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, 2023-12-04 at 13:28 -0800, Marc MERLIN wrote: > > Where do you we go from here? Is the patch obviously good/safe, or do we > need to narrow things down/test some more? > Well, I was hoping that (a) ethtool folks / Jakub would comment if this makes sense, but I don't see a good reason to do things the other way around (other than "code is simpler"); and (b) Intel wired folks could help out with getting the patch across the finish line, seeing how their driver needs it :) I think the dev get/put needs to use the newer API, but I didn't immediately see how that works locally in a function without an allocated tracker johannes _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan