From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3CDDC0032E for ; Thu, 26 Oct 2023 00:20:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 473CF60E7C; Thu, 26 Oct 2023 00:20:33 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 473CF60E7C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1698279633; bh=DyEHR5hX81MThskXp5NSSExSLsh6mIHsEH42WxTYRdY=; h=Date:To:References:From:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=knsR8A59wxobeoMba/hPpuR47ee3oQ/kC/UpmARDzxg44DDc9kZenuHga2MVWR+UZ vKD6OjiznnCzlPs09zKzEa0Ipn1W3+7DZNbOGO5s5mbhX/WhZi628TRdwdbMLlC2e8 2+7p7bYsntNCqLIejkCPmMjlpSTtdIpwu/RSWHrjGW+YQyo5X8OB1CZsHNNd8+Z9tA 86DngC6P3L7yGsCZtnKtPDDFeJtAAlJ6ZB6qc53dpcDAzpdOtdP23sCZ6+9Gw4QO1D B4U63WNQf8UBc1HIyIV1wqsmI+0ejwbrc87hUaCW+oo2bXEF9izduNWk1Bh6QCNbiO KYj7uVAs7+uuQ== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1W7e54awJjL6; Thu, 26 Oct 2023 00:20:32 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 3EAD860E7E; Thu, 26 Oct 2023 00:20:32 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 3EAD860E7E Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id A97EF1BF3CE for ; Thu, 26 Oct 2023 00:20:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 8968240A1F for ; Thu, 26 Oct 2023 00:20:30 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 8968240A1F X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bKE7WTKxZTYw for ; Thu, 26 Oct 2023 00:20:29 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by smtp2.osuosl.org (Postfix) with ESMTPS id 092014012D for ; Thu, 26 Oct 2023 00:20:27 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 092014012D X-IronPort-AV: E=McAfee;i="6600,9927,10874"; a="390285438" X-IronPort-AV: E=Sophos;i="6.03,252,1694761200"; d="scan'208";a="390285438" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Oct 2023 17:20:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10874"; a="762625076" X-IronPort-AV: E=Sophos;i="6.03,252,1694761200"; d="scan'208";a="762625076" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga007.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 25 Oct 2023 17:20:16 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Wed, 25 Oct 2023 17:20:15 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Wed, 25 Oct 2023 17:20:15 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Wed, 25 Oct 2023 17:20:15 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Wed, 25 Oct 2023 17:20:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=erMVVDnjtSadyPJsDQlAYsEF/1b3har0WGiJSu3rlivbYN7vMsGEZL2wnParNHVrBSVqGFk710m4jJeIiQcmwSdEG0PTDlPX23z/gsxkQVoUCTnhHBMWDkoZgqp+Wg0vyjtAR2EcaZ//ZHHUQvEEocAFlDkj43AA+ZVwhruI4b6aCc3XrkW2Ll3SS0lKzLgL/ZXgpC+SdZsxjNBVAneqhtZeiq/oqQYraABf7SwIbjf/1k9h8G1ZeM7yatQVGg5MMBON8PDUsDGZNVPbeDDPr+ed9VcHp5yMwxRQcLOwBgxxMZoUMaZ+or0To/IRQLT0MiHHcB0+PIinfqd/+8JmrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d6CnOH4jDprdyxRTxT3zreqosuKUyUb7jE1etPiSn6k=; b=oc/6uMKwPpNuY4a7nDizRGY6kzKs3ic8WAr1Kj8rgi2ybE2YNyL30Bu1MzQfm71sXGiT162ITADjr4ElvjfqSg7hRzN5atAsgMVOnglvj/UDT/nGfo6dJl9WyROEw7Ha5ZdvzTt3doTpGx92719VivSlT3QSwju1eYGd9IxTctccjoQahiav6qwgK3kURDeK/tePUHpTGAHOkyqCDIqFfJKU6QDrvD8vNR7dQZf+BpiZzHG9Bi9mZ9mPxCEbNeaVbVN0m0ec3lmA/fc3WG+amf2tQFvHWV/WD+Vga5v0d3RQ0w7DHepnh6aMCLrTsBXW4HOzHSuAnkvPoHfsCFPuSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB5089.namprd11.prod.outlook.com (2603:10b6:303:9b::16) by IA0PR11MB8333.namprd11.prod.outlook.com (2603:10b6:208:491::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.21; Thu, 26 Oct 2023 00:20:05 +0000 Received: from CO1PR11MB5089.namprd11.prod.outlook.com ([fe80::f216:6b2b:3af0:35c1]) by CO1PR11MB5089.namprd11.prod.outlook.com ([fe80::f216:6b2b:3af0:35c1%4]) with mapi id 15.20.6907.032; Thu, 26 Oct 2023 00:20:05 +0000 Message-ID: <6d12707c-4666-40ac-9c8e-79b65f011263@intel.com> Date: Wed, 25 Oct 2023 17:20:02 -0700 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Jiri Pirko , Wojciech Drewek References: <20231025103315.1149589-1-ivecera@redhat.com> <20231025103315.1149589-2-ivecera@redhat.com> <8a8f54a8-1a18-4797-a592-b57bc6fc45c1@intel.com> From: Jacob Keller In-Reply-To: X-ClientProxiedBy: MW4PR02CA0016.namprd02.prod.outlook.com (2603:10b6:303:16d::22) To CO1PR11MB5089.namprd11.prod.outlook.com (2603:10b6:303:9b::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PR11MB5089:EE_|IA0PR11MB8333:EE_ X-MS-Office365-Filtering-Correlation-Id: cff095cf-90e0-4380-46f7-08dbd5b94dea X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dEftvsAWdagz3wJVyIJIkfyg4iCU4Q7lYT4siKHin9PpoRoN9EtRF81RymKVgqcWE9BQG6a/QnE0LXjRRYzHGNQG3TsQXgjgZJIWs1dRYcKU3PbwggOit9BkqjVrb2AYkwtQQb41OvoKKtClvND6LeLgHBC5AKJ1OU8kSPpozAayGijdGjnbNwFcKGtBn04Yt1aVD8wcO5K8SuAKaCUvRkXOj9HIMuh4TjZkLLJi7eb2yVkTKqyBI+pFhw6tPb+I5OQyGyhTWQFqWvGjW5aJ8DyzcUxFc8zFdGXtbrBYqXhR9cZFGT3PaGUeKi3lHIvRNiFhkuZYp7sLGvhDg/TQ/9VP5dX+xf/mkyG4mzL9osK5Cyg9908wzxl482s8Dmhn4KCxUuWiCAtlovFvz/rJe7m8ezuTrXWqeqHX7l0GmDXmMuEN5QeHFrRcijdeDKvIzWb4XIckuOUQgcq0aZTipzRgefOVC8oPcqALFxQ+PuXmgiHkbMHRYGBbjKq3AN7ywfgvoBhXJ/1hufhZia+XQLyve1sVIuvnnMGWZiXKRGDY9H8GpSEFYK/wk/iRVePPS412KlP1UqZY/lJMxIZZvEZRKeAMH+x06Pj9m1HbTOf0m6n9/MfxJrrmhe3eNlZpRPZ/kSTaAIiKS6eGMDTVgQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR11MB5089.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(136003)(346002)(366004)(39860400002)(396003)(230922051799003)(1800799009)(64100799003)(186009)(451199024)(478600001)(6486002)(66946007)(66476007)(82960400001)(38100700002)(86362001)(2616005)(83380400001)(36756003)(31696002)(26005)(316002)(31686004)(110136005)(6506007)(53546011)(6636002)(66556008)(6512007)(2906002)(6666004)(54906003)(41300700001)(8676002)(5660300002)(8936002)(4326008)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?LzRMOUF4WUtBdlFXdmFBUmZyL2kzQ0ZwdU55OU1RLzJXRDE5T0xOT2ZOZ2NU?= =?utf-8?B?Nmxhd3RHM2s4ZmFNVkdtczR1UUNLaVkra3RnK0RNQWhuem1oYysydTV1V1ha?= =?utf-8?B?UUw1WnZkeTk1Nk5OcjM5WlV6T1ZWMWlvRDBpUkozRjBjVzdXSm1mNVkwTnJp?= =?utf-8?B?NXhQRHE4RlJ6dWFLa3FZcHZRSm1jdXIwUFBOR1dYWW14R25iRm9wQUJQZml1?= =?utf-8?B?ZGRkNnpsOHBTOURvTUxmeUVoY3NIY21FQW9mTDFjcDZKcjl6Z0d2ejNwUHFF?= =?utf-8?B?NEwzTld2R1pPUEsrcU53YmEzVk5WVU5YQmRlSjNVT3JxN1FvNTJTcU14V3lV?= =?utf-8?B?eG9MS2Z2M01UUGk1c2ZxZXU3WTdBYjdGVEhWK3ZMRitObm5lTzVzNDh1Wm12?= =?utf-8?B?WGdhNWR0OWlObEZhNjFhalowNEZqZVVjaXQzK2wvOG5teWoyL0ViK2NqOW1E?= =?utf-8?B?YWNobkhGY0lQWUp2TFdEb1FxUWo1dldLbzdtakxVclpmOUhVY3d4cmlCcGhu?= =?utf-8?B?VndaMVVueXNPTUxKWFIrVitaT1hBdHRYN2hnMndUR1hUQllyMW9rQy9yQnFw?= =?utf-8?B?RWtJbDdkZFdyRE1IOThnOEN0UmxwQWUvbDVvSWhUVjdtSzNYcDdRRkdyOUlr?= =?utf-8?B?Q0ZNbGZ0SDV5dHNsbWhsR2tEQmxFelpGK0FFc2NaS1QzUE1JODg1dnU3aXJs?= =?utf-8?B?bTZwbnJCS283b0hyVDh2WHZxR1VseTFtdld0cHVob1lwaklUNTI5NmxTNFR0?= =?utf-8?B?VDVlaGFNcFJZWmx1ZUdIbTc4dzFrSDhpRlIyNjZqMFl0Z1VYWm1COE01Z3dV?= =?utf-8?B?b2NlSXdrNFFEZkYyWEhRaXpqOUxlUTVIbmk1N2ZhMitOMFE5TWtMM2pGSXhU?= =?utf-8?B?UHI1ZXJ6cnJBZVVUbDI5MWpYTk1waW5ibGtUOHVJR3pPclZ4VU9hRklpVGpU?= =?utf-8?B?bWJ3U3o4QUJDQUlkNFNFTzUzS2NzRXVqb0NnUkVQYmJ4cHF6cGdFYlg5cWJl?= =?utf-8?B?NkpNcTNMV0NZNExVTHZiY3JKZEhmTE84T3ZnVkdnOTArK0lKZzVDTVB1OTY5?= =?utf-8?B?dWZTdW5ZdXEyRTMzQUdMd2V6OHpZdjQvdkI3QStGWmFXZGlpbGo0S3RvOG5G?= =?utf-8?B?N3NNNUZUdjVHM1VIb3VIL2VPU25EOWVZU2srMzBVTlBJNyt0ZklRQzREdUlV?= =?utf-8?B?MTd1ZklrcDFRejFnSmFUYjdubWU5RkZFaTdqMnB4SjQyUlY5TjJhMUlycTdP?= =?utf-8?B?ZmNHY25XaVRFVDBQZ2FLN2JBWUphcFhFVWY4eW5za0ZoNUh5QmVuTmd3OFd2?= =?utf-8?B?SUhQWnFtcENvK1hHbG0yM3VtcjJEWkpVOHlkd1p6Skt5eDNlckZEb1RXZ201?= =?utf-8?B?YWNmS01RSXFtcjk1ZEdKTGtWSkZocDZpQktoVHNpb2t0ZHBXdDk4cXIveEI2?= =?utf-8?B?NGZoYUhwZ1crMjRBZVFiQjFzdEVtOXk0emJrbnFIcUZTQ2NIaG5hTFpFc0VS?= =?utf-8?B?MXRXd2VYUUVyclVSU1Vqc3lTM2V4L2pZMTFiR0FYNVQ1OGZSNG4waVdXZ25q?= =?utf-8?B?TjY1a29EbzlFK3EvalVoSit5NUx0THd2cDNVQmEwQmlueU1NaC8xWEZ4SWlx?= =?utf-8?B?cFpTYUtKUHBiWGpHN0xjQmtqQTcyeEtBbm5SdGQvelJMVGdpZ3F2bCt2WVNa?= =?utf-8?B?MDJKUmJ0S3czN3FJNWhQZ29oeGg0VGhsK21adlpKSFdydW1mWTFSUW5DK2tC?= =?utf-8?B?M1IwQXNxQW16OTZralFoUjVOODFlSFVHWlZWZzh6L0FZckRzZGI3YjVsYk1j?= =?utf-8?B?aTdZK3FYcGxVdEFrSHBhUDNQRzI3dUw3enFwWlRPWEJDcW5OV0pGNnpZYUxy?= =?utf-8?B?UFBMUDZtNlBPMkExMmhZQjJrMzBYYi9Tcm1tclk1VGFveHFNbUxINzNINHg0?= =?utf-8?B?REd0UmZyNjVRVWs1OVM1ekpOOGFjVnVuV3podDF3R05NejBCL1lHNVVIendy?= =?utf-8?B?YlZHWlg1U08wNFRDNWpWa0p0c3hNWVdQTGZzOXNRdm16UzczRm5XTFlHdllp?= =?utf-8?B?dWtLMWhaWVVZOVBoMWtYa0JHVS8ycUQ2Wm9heUc2NkNPOVMxNm5uY0xWMEls?= =?utf-8?B?dmxtQUFMWmJWd1ZueTZKU3o1bWJJQitQQjlJRHRUQTZxemkwcFR5T05mRFBL?= =?utf-8?B?S0E9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: cff095cf-90e0-4380-46f7-08dbd5b94dea X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2023 00:20:05.6982 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CtBU8vlfocR5CxvD+CZ6Dkqpldr13iuW+WuHio09Lh2xCyA1sXk18FGHcuk5EEXFgYuryBuiTLNAwqUJY5H1JhAwzWJoN86raqHBAGLwh0Q= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB8333 X-OriginatorOrg: intel.com X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698279629; x=1729815629; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=qJ+GlWUF9KQoO82K8l7rP8XoL76tSzuMTXyVfP6jimw=; b=AhR9dQcLDglLPgBa+zgkSBsAbY3k17MklOKWthMfy9CDphlzGGGhV1Oi imL8Cn7vjTD2IxquP8CI7E9FzQ0CKkn+ejmysoUZ7+D6CsF7H9kGGUHPt 86RqTHa3jPJuFWl+LySbaRRuuMqKMu25/gOGzHcXWDLdisbPF4uBhmnxL nCZsRk8/WYTm6xHk9nTJCUsmfkzvC392ywcvmtfwz96+66xbFiMu+0/S2 GVvx8zMkAbbauYZZArW81A0uoqKV4E8W9/trI3IXhAkmIJ2U0/VomsDZR zFkhaL1ie6GtIw4z753TTXREs8675uxeeqvAtgpLUHYW9sPMjvm+EZGGY g==; X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=AhR9dQcL X-Mailman-Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Subject: Re: [Intel-wired-lan] [PATCH iwl-next 1/2] i40e: Remove VF MAC types X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, Jesse Brandeburg , linux-kernel@vger.kernel.org, Eric Dumazet , Tony Nguyen , intel-wired-lan@lists.osuosl.org, Jakub Kicinski , Paolo Abeni , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On 10/25/2023 5:20 AM, Jiri Pirko wrote: > Wed, Oct 25, 2023 at 02:16:39PM CEST, jiri@resnulli.us wrote: >> Wed, Oct 25, 2023 at 12:48:37PM CEST, wojciech.drewek@intel.com wrote: >>> >>> >>> On 25.10.2023 12:33, Ivan Vecera wrote: >>>> The i40e_hw.mac.type cannot to be equal to I40E_MAC_VF or >>>> I40E_MAC_X722_VF so remove helper i40e_is_vf(), simplify >>>> i40e_adminq_init_regs() and remove enums for these VF MAC types. >>>> >>>> Signed-off-by: Ivan Vecera >>>> --- >>>> drivers/net/ethernet/intel/i40e/i40e_adminq.c | 33 ++++++------------- >>>> drivers/net/ethernet/intel/i40e/i40e_type.h | 8 ----- >>>> 2 files changed, 10 insertions(+), 31 deletions(-) >>>> >>>> diff --git a/drivers/net/ethernet/intel/i40e/i40e_adminq.c b/drivers/net/ethernet/intel/i40e/i40e_adminq.c >>>> index 29fc46abf690..896c43905309 100644 >>>> --- a/drivers/net/ethernet/intel/i40e/i40e_adminq.c >>>> +++ b/drivers/net/ethernet/intel/i40e/i40e_adminq.c >>>> @@ -17,29 +17,16 @@ static void i40e_resume_aq(struct i40e_hw *hw); >>>> static void i40e_adminq_init_regs(struct i40e_hw *hw) >>>> { >>>> /* set head and tail registers in our local struct */ >>>> - if (i40e_is_vf(hw)) { >>>> - hw->aq.asq.tail = I40E_VF_ATQT1; >>>> - hw->aq.asq.head = I40E_VF_ATQH1; >>>> - hw->aq.asq.len = I40E_VF_ATQLEN1; >>>> - hw->aq.asq.bal = I40E_VF_ATQBAL1; >>>> - hw->aq.asq.bah = I40E_VF_ATQBAH1; >>>> - hw->aq.arq.tail = I40E_VF_ARQT1; >>>> - hw->aq.arq.head = I40E_VF_ARQH1; >>>> - hw->aq.arq.len = I40E_VF_ARQLEN1; >>>> - hw->aq.arq.bal = I40E_VF_ARQBAL1; >>>> - hw->aq.arq.bah = I40E_VF_ARQBAH1; >>> >>> What about removing those I40E_VF_* defines? >>> This is their only usage here, right? >> >> Wait, do you suggest to use the values directly? That would be >> wild even for i40e :) > > Ah, sec. This is duplicated in > drivers/net/ethernet/intel/iavf/iavf_register.h. That confused me. > Its possible the iAVF code could be cleaned up too... Historically the i40e and i40evf duplicated quite some code. _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan