Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v1 1/1] igc: Remove unused phy_type enum
Date: Wed, 13 Apr 2022 11:13:51 -0700	[thread overview]
Message-ID: <716d73f5-3e2d-0ed9-d9b9-356406988010@intel.com> (raw)
In-Reply-To: <20220413053317.3297670-1-sasha.neftin@intel.com>


On 4/12/2022 10:33 PM, Sasha Neftin wrote:

<snip>
> diff --git a/drivers/net/ethernet/intel/igc/igc_phy.c b/drivers/net/ethernet/intel/igc/igc_phy.c
> index 6961f65d36b9..4f06e6bb68b1 100644
> --- a/drivers/net/ethernet/intel/igc/igc_phy.c
> +++ b/drivers/net/ethernet/intel/igc/igc_phy.c
> @@ -150,13 +150,9 @@ s32 igc_check_downshift(struct igc_hw *hw)
>   	struct igc_phy_info *phy = &hw->phy;
>   	s32 ret_val;
>   
> -	switch (phy->type) {
> -	case igc_phy_i225:
> -	default:
> -		/* speed downshift not supported */
> -		phy->speed_downgraded = false;
> -		ret_val = 0;
> -	}
> +	/* speed downshift not supported */
> +	phy->speed_downgraded = false;
> +	ret_val = 0;
>   
>   	return ret_val;

ret_val isn't needed since it's always returning 0 and could possibly be 
made a void function.

Thanks,

Tony


  reply	other threads:[~2022-04-13 18:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-13  5:33 [Intel-wired-lan] [PATCH v1 1/1] igc: Remove unused phy_type enum Sasha Neftin
2022-04-13 18:13 ` Tony Nguyen [this message]
2022-04-14  6:15   ` Neftin, Sasha
2022-05-01  8:25 ` naamax.meir
2022-05-04  8:26 ` naamax.meir

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=716d73f5-3e2d-0ed9-d9b9-356406988010@intel.com \
    --to=anthony.l.nguyen@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox