From: "naamax.meir" <naamax.meir@linux.intel.com>
To: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>,
intel-wired-lan@osuosl.org, vinicius.gomes@intel.com
Cc: kuba@kernel.org, netdev@vger.kernel.org,
anthony.l.nguyen@intel.com, tee.min.tan@linux.intel.com,
davem@davemloft.net
Subject: Re: [Intel-wired-lan] [PATCH net-next v2] igc: offload queue max SDU from tc-taprio
Date: Sun, 1 Jan 2023 13:16:23 +0200 [thread overview]
Message-ID: <71b8226c-06c6-efac-50f6-6b4f43a61bc9@linux.intel.com> (raw)
In-Reply-To: <20221216150357.12721-1-muhammad.husaini.zulkifli@intel.com>
On 12/16/2022 17:03, Muhammad Husaini Zulkifli wrote:
> From: Tan Tee Min <tee.min.tan@linux.intel.com>
>
> Add support for configuring the max SDU for each Tx queue.
> If not specified, keep the default.
>
> All link speeds have been tested with this implementation.
> No performance issue observed.
>
> How to test:
>
> 1) Configure the tc with max-sdu
>
> tc qdisc replace dev $IFACE parent root handle 100 taprio \
> num_tc 4 \
> map 0 1 2 3 3 3 3 3 3 3 3 3 3 3 3 3 \
> queues 1@0 1@1 1@2 1@3 \
> base-time $BASE \
> sched-entry S 0xF 1000000 \
> max-sdu 1500 1498 0 0 0 0 0 0 0 0 0 0 0 0 0 0 \
> flags 0x2 \
> txtime-delay 0
>
> 2) Use network statistic to watch the tx queue packet to see if
> packet able to go out or drop.
>
> Signed-off-by: Tan Tee Min <tee.min.tan@linux.intel.com>
> Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
>
> ---
> V1 -> V2: Rework based on Vinicius's comment.
> ---
> ---
> drivers/net/ethernet/intel/igc/igc.h | 1 +
> drivers/net/ethernet/intel/igc/igc_main.c | 44 +++++++++++++++++++++++
> 2 files changed, 45 insertions(+)
Tested-by: Naama Meir <naamax.meir@linux.intel.com>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
prev parent reply other threads:[~2023-01-01 11:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 15:03 [Intel-wired-lan] [PATCH net-next v2] igc: offload queue max SDU from tc-taprio Muhammad Husaini Zulkifli
2023-01-01 11:16 ` naamax.meir [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71b8226c-06c6-efac-50f6-6b4f43a61bc9@linux.intel.com \
--to=naamax.meir@linux.intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@osuosl.org \
--cc=kuba@kernel.org \
--cc=muhammad.husaini.zulkifli@intel.com \
--cc=netdev@vger.kernel.org \
--cc=tee.min.tan@linux.intel.com \
--cc=vinicius.gomes@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox