Re: [Intel-wired-lan] [PATCH iwl-next v1 01/13] ixgbe: add initial devlink support

[Tony Nguyen <anthony.l.nguyen@intel.com>]

On 2/3/2025 7:03 AM, Jedrzej Jagielski wrote:
> Add an initial support for devlink interface to ixgbe driver.
> 
> Similarly to i40e driver the implementation doesn't enable
> devlink to manage device-wide configuration. Devlink instance
> is created for each physical function of PCIe device.
> 
> Create separate directory for devlink related ixgbe files
> and use naming scheme similar to the one used in the ice driver.
> 
> Add a stub for Documentation, to be extended by further patches.
> 
> Reviewed-by: Mateusz Polchlopek <mateusz.polchlopek@intel.com>
> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>

...

> @@ -11283,6 +11284,10 @@ static int ixgbe_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>   		goto err_ioremap;
>   	}
>   
> +	err = ixgbe_allocate_devlink(adapter);
> +	if (err)
> +		goto err_ioremap;

Looks like the unroll has an issue.

Smatch reports:
../drivers/net/ethernet/intel/ixgbe/ixgbe_main.c:11844 ixgbe_probe() 
warn: 'hw->hw_addr' from ioremap() not released on lines: 11844.

Thanks,
Tony

> +
>   	netdev->netdev_ops = &ixgbe_netdev_ops;
>   	ixgbe_set_ethtool_ops(netdev);
>   	netdev->watchdog_timeo = 5 * HZ;