From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: "Sokolowski, Jan" <jan.sokolowski@intel.com>,
"Keller, Jacob E" <jacob.e.keller@intel.com>,
"intel-wired-lan@osuosl.org" <intel-wired-lan@osuosl.org>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1] ice: remove rx_len_errors statistic
Date: Wed, 29 Nov 2023 12:03:07 +0100 [thread overview]
Message-ID: <76cd7acf-41be-513f-170b-8c2e57b704b6@intel.com> (raw)
In-Reply-To: <PH7PR11MB58190A571FC08D16E58AC8599983A@PH7PR11MB5819.namprd11.prod.outlook.com>
On 11/29/23 11:26, Sokolowski, Jan wrote:
>>
>> On 11/20/2023 3:27 AM, Jan Sokolowski wrote:
>>> It was found that this statistic is incorrectly reported
>>> by HW and thus, useless.
>>>
>>> Remove it.
>>
>> Is there any further information about what is reported incorrectly? Is
>> rx_length_errors part of netdev stats and standardized? Does HW fail to
>> report some packets or does it report packets which don't have an issue?
Great questions
>>
>
> It's a part of visible stats, standardized.
Please add that info into commit message of v2, and CC netdev.
Perhaps one could ask if it would be better to always-report-zero as
a value of that, standardized, stat. But if we could just remove it,
it's better.
>
> According to the bug report, HW was misreporting packets that did not have any issues.
>
>> I mean the hardware does *something*, so I think it would be good to
>> have an understanding of how this differs from what we expected when
>> proposing to remove it.
>>
>> Thanks,
>> Jake
>> _______________________________________________
>> Intel-wired-lan mailing list
>> Intel-wired-lan@osuosl.org
>> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-11-29 11:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 11:27 [Intel-wired-lan] [PATCH iwl-next v1] ice: remove rx_len_errors statistic Jan Sokolowski
2023-11-20 21:48 ` Jacob Keller
2023-11-29 10:26 ` Sokolowski, Jan
2023-11-29 11:03 ` Przemek Kitszel [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-12-06 10:43 Jan Sokolowski
2023-12-07 23:33 ` Tony Nguyen
2023-12-11 4:58 ` Pucha, HimasekharX Reddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76cd7acf-41be-513f-170b-8c2e57b704b6@intel.com \
--to=przemyslaw.kitszel@intel.com \
--cc=intel-wired-lan@osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=jan.sokolowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox