Re: [Intel-wired-lan] [PATCH net-next 05/15] ice: always call ice_ptp_link_change and make it void

[Tony Nguyen <anthony.l.nguyen@intel.com>]

On 11/1/2022 3:52 PM, Jacob Keller wrote:
> The ice_ptp_link_change function is currently only called for E822 based
> hardware. Future changes are going to extend this function to perform
> additional tasks on link change.
> 
> Always call this function, moving the e810 check from the callers down to
> just before we call the E822-specific function required to restart the PHY.
> 
> This function also returns an error value, but none of the callers actually
> check it. In general, the errors it produces are more likely systemic
> problems such as invalid or corrupt port numbers. No caller checks these,
> and so no warning is logged.
> 
> Re-order the flag checks so that ICE_FLAG_PTP is checked first. Drop the
> unnecessary check for ICE_FLAG_PTP_SUPPORTED, as ICE_FLAG_PTP will not be
> set except when ICE_FLAG_PTP_SUPPORTED is set.
> 
> Convert the port checks to WARN_ON_ONCE, in order to generate a kernel
> stack trace when they are hit.
> 
> Convert the function to void since no caller actually checks these return
> values.
> 
> Co-authored-by: Dave Ertman <david.m.ertman@intel.com>

Checkpatch is reporting this:
WARNING: Non-standard signature: Co-authored-by:

I see this used in the git log, however, seems like a Co-developed-by & 
Signed-off-by would communicate the same and make checkpatch happy.

> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan