Re: [Intel-wired-lan] [PATCH iwl-net v2] ice: Block switchdev mode when ADQ is active and vice versa

[Marcin Szycik <marcin.szycik@linux.intel.com>]

On 08.08.2023 19:55, Tony Nguyen wrote:
> On 8/4/2023 7:26 AM, Marcin Szycik wrote:
>> ADQ and switchdev are not supported simultaneously. Enabling both at the
>> same time can result in nullptr dereference.
>>
>> To prevent this, check if ADQ is active when changing devlink mode to
>> switchdev mode, and check if switchdev is active when enabling ADQ.
>>
>> Fixes: fbc7b27af0f9 ("ice: enable ndo_setup_tc support for mqprio_qdisc")
>> Signed-off-by: Marcin Szycik <marcin.szycik@linux.intel.com>
>> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
>> ---
> 
> ...
> 
>> @@ -8834,6 +8834,12 @@ ice_setup_tc(struct net_device *netdev, enum tc_setup_type type,
>>               }
>>           }
>>   +        if (ice_is_eswitch_mode_switchdev(pf)) {
>> +            netdev_err(netdev, "TC MQPRIO offload not supported, switchdev is enabled\n");
>> +            err = -EOPNOTSUPP;
>> +            goto adev_unlock;
> 
> Does this need to be checked under adev locks?

It doesn't. I'll move it above.

> 
>> +        }
>> +
>>           /* setup traffic classifier for receive side */
>>           mutex_lock(&pf->tc_mutex);
>>           err = ice_setup_tc_mqprio_qdisc(netdev, type_data);

Thank you for reviewing!
Marcin
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan