From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH 1/3] treewide: Lift switch variables out of switches
Date: Wed, 23 Jan 2019 08:51:38 -0800 [thread overview]
Message-ID: <7d8a6120ea335d74c41a5fba3754518ea60e936e.camel@intel.com> (raw)
In-Reply-To: <20190123110349.35882-2-keescook@chromium.org>
On Wed, 2019-01-23 at 03:03 -0800, Kees Cook wrote:
> Variables declared in a switch statement before any case statements
> cannot be initialized, so move all instances out of the switches.
> After this, future always-initialized stack variables will work
> and not throw warnings like this:
>
> fs/fcntl.c: In function ?send_sigio_to_task?:
> fs/fcntl.c:738:13: warning: statement will never be executed [-
> Wswitch-unreachable]
> siginfo_t si;
> ^~
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
For the e1000 changes.
> ---
> arch/x86/xen/enlighten_pv.c | 7 ++++---
> drivers/char/pcmcia/cm4000_cs.c | 2 +-
> drivers/char/ppdev.c | 20 ++++++++---------
> --
> drivers/gpu/drm/drm_edid.c | 4 ++--
> drivers/gpu/drm/i915/intel_display.c | 2 +-
> drivers/gpu/drm/i915/intel_pm.c | 4 ++--
> drivers/net/ethernet/intel/e1000/e1000_main.c | 3 ++-
> drivers/tty/n_tty.c | 3 +--
> drivers/usb/gadget/udc/net2280.c | 5 ++---
> fs/fcntl.c | 3 ++-
> mm/shmem.c | 5 +++--
> net/core/skbuff.c | 4 ++--
> net/ipv6/ip6_gre.c | 4 ++--
> net/ipv6/ip6_tunnel.c | 4 ++--
> net/openvswitch/flow_netlink.c | 7 +++----
> security/tomoyo/common.c | 3 ++-
> security/tomoyo/condition.c | 7 ++++---
> security/tomoyo/util.c | 4 ++--
> 18 files changed, 45 insertions(+), 46 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20190123/cd7b302b/attachment.asc>
next prev parent reply other threads:[~2019-01-23 16:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 11:03 [Intel-wired-lan] [PATCH 0/3] gcc-plugins: Introduce stackinit plugin Kees Cook
2019-01-23 11:03 ` [Intel-wired-lan] [PATCH 1/3] treewide: Lift switch variables out of switches Kees Cook
2019-01-23 11:58 ` Greg KH
2019-01-23 12:09 ` Jann Horn
2019-01-23 12:12 ` Ard Biesheuvel
2019-01-23 13:21 ` William Kucharski
2019-01-23 14:17 ` [Intel-wired-lan] [Intel-gfx] " Jani Nikula
2019-01-23 14:23 ` Jani Nikula
2019-01-23 14:47 ` Edwin Zimmerman
2019-01-23 15:46 ` Jani Nikula
2019-01-23 18:55 ` Kees Cook
2019-01-24 8:10 ` Greg KH
2019-01-23 19:18 ` Matthew Wilcox
2019-01-23 20:36 ` Kees Cook
2019-01-23 16:51 ` Jeff Kirsher [this message]
2019-01-24 12:58 ` [Intel-wired-lan] " Edwin Zimmerman
2019-01-23 11:03 ` [Intel-wired-lan] [PATCH 2/3] gcc-plugins: Introduce stackinit plugin Kees Cook
2019-01-23 11:03 ` [Intel-wired-lan] [PATCH 3/3] lib: Introduce test_stackinit module Kees Cook
2019-01-29 0:12 ` [Intel-wired-lan] [PATCH 0/3] gcc-plugins: Introduce stackinit plugin Alexander Popov
2019-02-12 17:54 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d8a6120ea335d74c41a5fba3754518ea60e936e.camel@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox