Re: [Intel-wired-lan] [PATCH net-next v2 0/2] i40e: Fix ethtool rx-flow-hash setting for X722

[Tony Nguyen <anthony.l.nguyen@intel.com>]

On 7/12/2022 7:16 AM, Mateusz Palczewski wrote:
> From: Michal Jaron <michalx.jaron@intel.com>
> 
> When enabling flow type for RSS hash via ethtool:
> 
>    ethtool -N $pf rx-flow-hash tcp4|tcp6|udp4|udp6 s|d
> 
> the driver would fail to setup this setting on X722
> device since it was using the mask on the register
> dedicated for X710 devices.
> 
> Implement a bitmap to collect the flow pc types that
> shall be applied on the inset and hena registers.
> Apply a different mask on the register when setting the
> RSS hash for the X722 device.

This should be split. Patch one should go to net and patch two to -next 
as one is a bug fix and one is a refactor.

Also, both patches have the same issues:

ERROR: Unrecognized email address: 'Slawomir Laba slawomirx.laba@intel.com'

Based on sign-off ordering, I would expect Slawomir to be the author, 
however, it's currently listed as Michal. Please either fix ordering to 
have Michal first if he is the author or change the author to be Slawomir.

> Michal Jaron (2):
>    i40e: Fix ethtool rx-flow-hash setting for X722
>    i40e: Refactor i40e_set_rss_hash_opt
> 
>   .../net/ethernet/intel/i40e/i40e_ethtool.c    | 105 +++++++++++-------
>   drivers/net/ethernet/intel/i40e/i40e_type.h   |   4 +
>   2 files changed, 69 insertions(+), 40 deletions(-)
> 
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan