Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nguyen, Anthony L <anthony.l.nguyen@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net v2] iavf: Fix init and watchdog state machines
Date: Wed, 14 Apr 2021 21:45:34 +0000	[thread overview]
Message-ID: <84bb456c862e0b3919c4c82f703b90d16a79a8b0.camel@intel.com> (raw)
In-Reply-To: <20210413114332.32650-1-mateusz.palczewski@intel.com>

On Tue, 2021-04-13 at 11:43 +0000, Mateusz Palczewski wrote:
> From: Jan Sokolowski <jan.sokolowski@intel.com>
> 
> Use single state machine for driver initialization
> and for service initialized driver. The init state
> machine implemented in init_task() is merged
> into the watchdog_task(). The init_task() function
> is removed.

It's unclear to me what's being fixed here. This sounds like a
refactor. If so, it should go to -next.

Also, feedback from the previous version has not been addressed. There
is a new state and helper function, but no explanation of it here.

> Testing-Hints: Change is only for VF driver state machine,
>                should be checked load/unload/reset and
>                set/get driver parameters.
> 
> Fixes: bac8486116b0 ("iavf: Refactor the watchdog state machine")
> Signed-off-by: Jakub Pawlak <jakub.pawlak@intel.com>
> Signed-off-by: Jan Sokolowski <jan.sokolowski@intel.com>
> ---
>  v2: splitted the patch into smaller pieces
> ---
>  drivers/net/ethernet/intel/iavf/iavf.h      |   2 +-
>  drivers/net/ethernet/intel/iavf/iavf_main.c | 159 ++++++++++------
> ----
>  2 files changed, 77 insertions(+), 84 deletions(-)

      reply	other threads:[~2021-04-14 21:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-13 11:43 [Intel-wired-lan] [PATCH net v2] iavf: Fix init and watchdog state machines Mateusz Palczewski
2021-04-14 21:45 ` Nguyen, Anthony L [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84bb456c862e0b3919c4c82f703b90d16a79a8b0.camel@intel.com \
    --to=anthony.l.nguyen@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox