From: Jacob Keller <jacob.e.keller@intel.com>
To: Ruan Jinjie <ruanjinjie@huawei.com>, <sgoutham@marvell.com>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <jesse.brandeburg@intel.com>,
<anthony.l.nguyen@intel.com>, <tariqt@nvidia.com>,
<s.shtylyov@omp.ru>, <aspriel@gmail.com>,
<franky.lin@broadcom.com>, <hante.meuleman@broadcom.com>,
<kvalo@kernel.org>, <richardcochran@gmail.com>,
<yoshihiro.shimoda.uh@renesas.com>,
<u.kleine-koenig@pengutronix.de>, <mkl@pengutronix.de>,
<lee@kernel.org>, <set_pte_at@outlook.com>,
<linux-arm-kernel@lists.infradead.org>, <netdev@vger.kernel.org>,
<intel-wired-lan@lists.osuosl.org>, <linux-rdma@vger.kernel.org>,
<linux-renesas-soc@vger.kernel.org>,
<linux-wireless@vger.kernel.org>,
<brcm80211-dev-list.pdl@broadcom.com>,
<SHA-cyfmac-dev-list@infineon.com>
Subject: Re: [Intel-wired-lan] [PATCH -next 2/6] ethernet/intel: Remove unnecessary ternary operators
Date: Mon, 7 Aug 2023 10:35:52 -0700 [thread overview]
Message-ID: <84f63b86-6d7d-9547-d4b7-d66a44b23c30@intel.com> (raw)
In-Reply-To: <20230804035346.2879318-3-ruanjinjie@huawei.com>
On 8/3/2023 8:53 PM, Ruan Jinjie wrote:
> Ther are a little ternary operators, the true or false judgement
> of which is unnecessary in C language semantics.
>
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
> ---
> drivers/net/ethernet/intel/igb/e1000_phy.c | 2 +-
> drivers/net/ethernet/intel/igc/igc_phy.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/igb/e1000_phy.c b/drivers/net/ethernet/intel/igb/e1000_phy.c
> index a018000f7db9..c123c9dd6a49 100644
> --- a/drivers/net/ethernet/intel/igb/e1000_phy.c
> +++ b/drivers/net/ethernet/intel/igb/e1000_phy.c
> @@ -1652,7 +1652,7 @@ s32 igb_phy_has_link(struct e1000_hw *hw, u32 iterations,
> udelay(usec_interval);
> }
>
> - *success = (i < iterations) ? true : false;
> + *success = i < iterations;
>
> return ret_val;
> }
> diff --git a/drivers/net/ethernet/intel/igc/igc_phy.c b/drivers/net/ethernet/intel/igc/igc_phy.c
> index 53b77c969c85..a553e9d719e7 100644
> --- a/drivers/net/ethernet/intel/igc/igc_phy.c
> +++ b/drivers/net/ethernet/intel/igc/igc_phy.c
> @@ -93,7 +93,7 @@ s32 igc_phy_has_link(struct igc_hw *hw, u32 iterations,
> udelay(usec_interval);
> }
>
> - *success = (i < iterations) ? true : false;
> + *success = i < iterations;
>
> return ret_val;
> }
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-08-07 17:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 3:53 [Intel-wired-lan] [PATCH -next 0/6] net: Remove unnecessary ternary operators Ruan Jinjie
2023-08-04 3:53 ` [Intel-wired-lan] [PATCH -next 1/6] net: thunderx: " Ruan Jinjie
2023-08-07 1:39 ` Ping-Ke Shih
2023-08-07 4:59 ` Ruan Jinjie
2023-08-07 17:34 ` Jacob Keller
2023-08-04 3:53 ` [Intel-wired-lan] [PATCH -next 2/6] ethernet/intel: " Ruan Jinjie
2023-08-07 17:35 ` Jacob Keller [this message]
2023-08-04 3:53 ` [Intel-wired-lan] [PATCH -next 3/6] net/mlx4: Remove an unnecessary ternary operator Ruan Jinjie
2023-08-07 1:41 ` Ping-Ke Shih
2023-08-07 5:00 ` Ruan Jinjie
2023-08-04 3:53 ` [Intel-wired-lan] [PATCH -next 4/6] net: ethernet: renesas: rswitch: " Ruan Jinjie
2023-08-04 3:53 ` [Intel-wired-lan] [PATCH -next 5/6] net: fjes: " Ruan Jinjie
2023-08-04 3:53 ` [Intel-wired-lan] [PATCH -next 6/6] brcm80211: " Ruan Jinjie
2023-08-07 1:42 ` Ping-Ke Shih
2023-08-07 5:00 ` Ruan Jinjie
2023-08-04 20:17 ` [Intel-wired-lan] [PATCH -next 0/6] net: Remove unnecessary ternary operators Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84f63b86-6d7d-9547-d4b7-d66a44b23c30@intel.com \
--to=jacob.e.keller@intel.com \
--cc=SHA-cyfmac-dev-list@infineon.com \
--cc=anthony.l.nguyen@intel.com \
--cc=aspriel@gmail.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=ruanjinjie@huawei.com \
--cc=s.shtylyov@omp.ru \
--cc=set_pte_at@outlook.com \
--cc=sgoutham@marvell.com \
--cc=tariqt@nvidia.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox