From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>,
<intel-wired-lan@lists.osuosl.org>,
"Kwapulinski, Piotr" <piotr.kwapulinski@intel.com>
Cc: <przemyslaw.kitszel@intel.com>
Subject: Re: [Intel-wired-lan] [iwl-next v1] ixgbe: use little endian type in admin commands
Date: Mon, 18 Nov 2024 15:02:35 -0800 [thread overview]
Message-ID: <85acafb4-502d-44d8-a387-6b261f01c116@intel.com> (raw)
In-Reply-To: <20241114081220.85602-1-michal.swiatkowski@linux.intel.com>
On 11/14/2024 12:12 AM, Michal Swiatkowski wrote:
> Firmware is always using little endian. Mark it using __le prefixed type
> in all admin commands structures.
>
> Do a proper conversion whenever the structures are used.
>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> ---
> To be squashed with commit ea007e0cd2dc
> ("ixgbe: Add support for E610 FW Admin Command Interface")
These changes look to involve at least two commits from the original
series [1] i.e. does not squash with the mentioned patch.
It's probably going to work best if these changes get rolled into the
respective patches of the series as a new version.
Thanks,
Tony
[1]
https://lore.kernel.org/intel-wired-lan/20241023124358.6967-1-piotr.kwapulinski@intel.com/
next prev parent reply other threads:[~2024-11-18 23:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-14 8:12 [Intel-wired-lan] [iwl-next v1] ixgbe: use little endian type in admin commands Michal Swiatkowski
2024-11-18 23:02 ` Tony Nguyen [this message]
2024-11-19 15:56 ` Kwapulinski, Piotr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85acafb4-502d-44d8-a387-6b261f01c116@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=michal.swiatkowski@linux.intel.com \
--cc=piotr.kwapulinski@intel.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox