Re: [Intel-wired-lan] [PATCH net v2] i40e: Fix not setting xps_cpus after reset

[Tony Nguyen <anthony.l.nguyen@intel.com>]

Hi Ivan,

On 9/29/2022 12:53 AM, Ivan Vecera wrote:
> On Tue, 13 Sep 2022 16:02:06 +0200
> Kamil Maziarz <kamil.maziarz@intel.com> wrote:
> 
>> From: Michal Jaron <michalx.jaron@intel.com>
>>
>> ...
> 
> Tony, I'd like to ask what did happen with this commit? During Monday you applied the patch to
> 40GBe branch as:
> 
> commit ce8d8ae335f469a399805f56e74b98390f327184
> Author: Michal Jaron <michalx.jaron@intel.com>
> Date:   Tue Sep 13 16:02:06 2022 +0200
> 
>      i40e: Fix not setting xps_cpus after reset
>      
>      During tx rings configuration default XPS queue config is set and
>      __I40E_TX_XPS_INIT_DONE is locked. XPS CPUs maps are cleared in
>      every reset by netdev_set_num_tc() call regardless it was set by
>      user or driver. If reset with reinit occurs __I40E_TX_XPS_INIT_DONE
>      flag is removed and XPS mapping is set to default again but after
>      reset without reinit this flag is still set and XPS CPUs to queues
>      mapping stays cleared.
>      
>      Add code to preserve xps_cpus mapping as cpumask for every queue
>      and restore those mapping at the end of reset.
>      
>      Fixes: 6f853d4f8e93 ("i40e: allow XPS with QoS enabled")
>      Signed-off-by: Michal Jaron <michalx.jaron@intel.com>
>      Signed-off-by: Kamil Maziarz <kamil.maziarz@intel.com>
>      Tested-by: Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Intel)
>      Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
> 
> but later the branch was force-pushed, the commit is not present there anymore nor
> in upstream...

I'm not sure exactly where you are referring to when you say upstream, 
but it is still currently on the IWL trees [1].

> Was it silently dropped? What was the reason?

When sent to netdev, there are questions/concerns with the patch [2]. As 
I mentioned in the netdev patch, in an effort to try to get the other 
patches in the series accepted for this kernel (since it's closing 
soon), I've omitted this patch from the pull request while the 
discussion continues. This may or may not be dropped from the tree based 
on where the netdev discussion goes.

For the IWL trees, dev-queue is the branch that you should follow. The 
other branches are branches for pull requests so their content is fluid 
and doesn't necessarily represent what is current with IWL patches.

Thanks,
Tony

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git/commit/?h=dev-queue&id=e312239075d77f11b45c3997a4e89153393c259d
[2] https://lore.kernel.org/netdev/20220927182933.30d691d2@kernel.org/#t
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan