Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Lifshits, Vitaly" <vitaly.lifshits@intel.com>
To: Timo Teras <timo.teras@iki.fi>
Cc: <intel-wired-lan@osuosl.org>, <en-wei.wu@canonical.com>,
	<marmarek@invisiblethingslab.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1 1/1] e1000e: Introduce private flag to disable K1
Date: Wed, 20 Aug 2025 09:43:38 +0300	[thread overview]
Message-ID: <876ce7de-dc6e-4e98-9cc6-593cfe8ab73d@intel.com> (raw)
In-Reply-To: <20250819201032.3873c62b@onyx.my.domain>

On 8/19/2025 8:10 PM, Timo Teras wrote:
> On Tue, 19 Aug 2025 15:43:26 +0300
> Vitaly Lifshits <vitaly.lifshits@intel.com> wrote:
> 
>> The K1 state reduces power consumption on ICH family network
>> controllers during idle periods, similarly to L1 state on PCI Express
>> NICs. Therefore, it is recommended and enabled by default.
>> However, on some systems it has been observed to have adverse side
>> effects, such as packet loss. It has been established through debug
>> that the problem may be due to firmware misconfiguration of specific
>> systems, interoperability with certain link partners, or marginal
>> electrical conditions of specific units.
>>
>> These problems typically cannot be fixed in the field, and generic
>> workarounds to resolve the side effects on all systems, while keeping
>> K1 enabled, were found infeasible.
>> Therefore, add the option for users to globally disable K1 idle state
>> on the adapter.
> 
> Thanks for adding this!
> 
> However, as a user, I find it inconvenient if the default setting
> results in a subtly broken system on a device I just from a store.
> 
> Since this affects devices from multiple large vendors, would it be
> possible to add some kind of quirk mechanism to automatically enable
> this on known "bad" systems. Perhaps something based on the DMI or other
> system specific information. Could something like this be implemented?
> 
> At least in my use case I have multiple e1000e using laptops on the
> same link partner working, and only one broken device for which I
> reported this issue. So at least on my experience the issue relates to
> specific system primarily (perhaps also requiring a specific link
> partner for the issue to show up).
> 
> Thanks!

Hi Timo,

Unfortunately, there is no visible configuration that allows the driver 
to reliably identify problematic systems.
If in the future we find such data, then we can improve the workaround 
and make it automatic.

At present, the user-controlled interface is the best we have.

  reply	other threads:[~2025-08-20  6:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-19 12:43 [Intel-wired-lan] [PATCH iwl-next v1 1/1] e1000e: Introduce private flag to disable K1 Vitaly Lifshits
2025-08-19 14:19 ` Loktionov, Aleksandr
2025-08-19 15:53   ` Lifshits, Vitaly
2025-08-19 17:10 ` Timo Teras
2025-08-20  6:43   ` Lifshits, Vitaly [this message]
2025-08-20  6:57     ` Timo Teras
2025-08-20 12:38       ` Lifshits, Vitaly
2025-08-20 13:26         ` Timo Teras
2025-08-20 13:51           ` Marek Marczykowski-Górecki
2025-08-21 17:11             ` Lifshits, Vitaly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=876ce7de-dc6e-4e98-9cc6-593cfe8ab73d@intel.com \
    --to=vitaly.lifshits@intel.com \
    --cc=en-wei.wu@canonical.com \
    --cc=intel-wired-lan@osuosl.org \
    --cc=marmarek@invisiblethingslab.com \
    --cc=timo.teras@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox