From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next-queue PATCH v1 2/4] igc: Add support for RX timestamping
Date: Tue, 26 Nov 2019 11:20:16 -0800 [thread overview]
Message-ID: <877e3mcumn.fsf@linux.intel.com> (raw)
In-Reply-To: <20191122020224.1102649-3-vinicius.gomes@intel.com>
Vinicius Costa Gomes <vinicius.gomes@intel.com> writes:
> This adds support for timestamping received packets.
>
> It is based on the i210, as many features of i225 work the same way.
> The main difference from i210 is that i225 has support for choosing
> the timer register to use when timestamping packets. Right now, we
> only support using timer 0. The other difference is that i225 stores
> two timestamps in the receive descriptor, right now, we only retrieve
> one.
>
> Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
> ---
[...]
> diff --git a/drivers/net/ethernet/intel/igc/igc_defines.h b/drivers/net/ethernet/intel/igc/igc_defines.h
> index fa345adad5c9..a5b7e5e05a89 100644
> --- a/drivers/net/ethernet/intel/igc/igc_defines.h
> +++ b/drivers/net/ethernet/intel/igc/igc_defines.h
> @@ -283,12 +283,21 @@
> #define IGC_RCTL_RDMTS_HALF 0x00000000 /* Rx desc min thresh size */
> #define IGC_RCTL_BAM 0x00008000 /* broadcast enable */
>
> +/* Split Replication Receive Control */
> +#define IGC_SRRCTL_TIMESTAMP 0x04000
I made a mistake here, it should read "0x40000000" or BIT(30). It's
causing timestamps to only be accessed via the registers, instead of via
the descriptors. Will send a v2 soon.
Cheers,
--
Vinicius
next prev parent reply other threads:[~2019-11-26 19:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 2:02 [Intel-wired-lan] [next-queue PATCH v1 0/4] igc: Add basic support for Timestamping/PTP Vinicius Costa Gomes
2019-11-22 2:02 ` [Intel-wired-lan] [next-queue PATCH v1 1/4] igc: Add basic skeleton for PTP Vinicius Costa Gomes
2019-11-22 2:02 ` [Intel-wired-lan] [next-queue PATCH v1 2/4] igc: Add support for RX timestamping Vinicius Costa Gomes
2019-11-26 19:20 ` Vinicius Costa Gomes [this message]
2019-11-22 2:02 ` [Intel-wired-lan] [next-queue PATCH v1 3/4] igc: Add support for TX timestamping Vinicius Costa Gomes
2019-11-22 2:02 ` [Intel-wired-lan] [next-queue PATCH v1 4/4] igc: Add support for ethtool GET_TS_INFO command Vinicius Costa Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877e3mcumn.fsf@linux.intel.com \
--to=vinicius.gomes@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox