From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E63E7EB64D8 for ; Wed, 21 Jun 2023 17:11:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 68B1E60C09; Wed, 21 Jun 2023 17:11:40 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 68B1E60C09 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1687367500; bh=eUyQnP/DZcWEBgfSGXSbBZmenje6fmCkrrQrgWeqI9g=; h=From:To:In-Reply-To:References:Date:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=g467EWdknUa7N3r5sCwxC4aAJJ/mpT6tu7Gig7KCYqPhJ00tiygdzABhmiF0wz81j n/6gVxDeOuK8PxzXOzuWFIaE4Y+HzJkD9v0uea2d66QktGiREauV9KIQe3pwa88gDB 0imLNvRmu+89WWVD43s/ST/cAgNvYkgVj+2sk5un0e50tj8cbsav3RF1CPwitTCuoB CMK4upXrSx+MqYloTB1jRCC7QzW9DlWnq3sFjtDJ0VBfwg93yRq6MXqqG8gUr2b3o/ 1YBNHKWO4WKgOkCEHb9/wKXkJN7K3+W9P9snVODtO6yVO6V707A9eTsrgDk9Uf7C+X QL8V2xVEGuDXw== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KrLNVmcvAavZ; Wed, 21 Jun 2023 17:11:39 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 318DA60B00; Wed, 21 Jun 2023 17:11:39 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 318DA60B00 Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 58B6E1BF2B1 for ; Wed, 21 Jun 2023 17:11:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 307EE60B00 for ; Wed, 21 Jun 2023 17:11:37 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 307EE60B00 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Q28qOU-Fycek for ; Wed, 21 Jun 2023 17:11:35 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 955E360AE9 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by smtp3.osuosl.org (Postfix) with ESMTPS id 955E360AE9 for ; Wed, 21 Jun 2023 17:11:35 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6600,9927,10748"; a="344977726" X-IronPort-AV: E=Sophos;i="6.00,261,1681196400"; d="scan'208";a="344977726" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2023 10:10:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10748"; a="714580017" X-IronPort-AV: E=Sophos;i="6.00,261,1681196400"; d="scan'208";a="714580017" Received: from jarteaga-mobl1.amr.corp.intel.com (HELO vcostago-mobl3) ([10.212.165.203]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2023 10:10:28 -0700 From: Vinicius Costa Gomes To: Kai-Heng Feng , jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com In-Reply-To: <20230620123636.1854690-1-kai.heng.feng@canonical.com> References: <20230620123636.1854690-1-kai.heng.feng@canonical.com> Date: Wed, 21 Jun 2023 10:10:27 -0700 Message-ID: <87cz1ospvg.fsf@intel.com> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687367495; x=1718903495; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=ouyyW1RWLlx0D/6B8cVMwnjeunonC+1tIEAPC3PI5cE=; b=Ev+59ZVDl4MGHrdKOUCnl74Njt/OSfxEKMBILgaC5jbyu6gH3t8U2s3e hXEyxzlPe+FNNFa/oTPts3osYZrP7XvK7fJWntrGcTJYagaM04kQW5K25 m0vxF4Vh9L+/7Epm+wTpKvcS/1ptghBq06XO2MdDOu6ELIanLzMlCwt9I qZ/ILsLUvdz6Md2Jp7ztLAJXwtvrdgPGfQs0CfiLK7S0k/r5qJl95OC06 QMceqH79+vrInixYZMtc06dQuU3EYzo8Z6/90v6hQeX17gNywjUNzN4KO ze4L0ohEpaEvjQEqLen2EpwU/8PB0Fa+EKSYu5JB3zYo53HQCucXS5JFd Q==; X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Ev+59ZVD Subject: Re: [Intel-wired-lan] [PATCH] igc: Ignore AER reset when device is suspended X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tony Luck , Kees Cook , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, "Guilherme G. Piccoli" , Eric Dumazet , Kai-Heng Feng , intel-wired-lan@lists.osuosl.org, linux-hardening@vger.kernel.org, netdev@vger.kernel.org, Jakub Kicinski , Paolo Abeni , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Kai-Heng Feng writes: > When a system that connects to a Thunderbolt dock equipped with I225, > I225 stops working after S3 resume: > > [ 606.527643] pcieport 0000:00:1d.0: AER: Multiple Corrected error received: 0000:00:1d.0 > [ 606.527791] pcieport 0000:00:1d.0: PCIe Bus Error: severity=Corrected, type=Transaction Layer, (Receiver ID) > [ 606.527795] pcieport 0000:00:1d.0: device [8086:7ab0] error status/mask=00008000/00002000 > [ 606.527800] pcieport 0000:00:1d.0: [15] HeaderOF > [ 606.527806] pcieport 0000:00:1d.0: AER: Error of this Agent is reported first > [ 606.527853] pcieport 0000:07:04.0: PCIe Bus Error: severity=Corrected, type=Data Link Layer, (Receiver ID) > [ 606.527856] pcieport 0000:07:04.0: device [8086:0b26] error status/mask=00000080/00002000 > [ 606.527861] pcieport 0000:07:04.0: [ 7] BadDLLP > [ 606.527931] pcieport 0000:00:1d.0: AER: Multiple Uncorrected (Non-Fatal) error received: 0000:00:1d.0 > [ 606.528064] pcieport 0000:00:1d.0: PCIe Bus Error: severity=Uncorrected (Non-Fatal), type=Transaction Layer, (Requester ID) > [ 606.528068] pcieport 0000:00:1d.0: device [8086:7ab0] error status/mask=00100000/00004000 > [ 606.528072] pcieport 0000:00:1d.0: [20] UnsupReq (First) > [ 606.528075] pcieport 0000:00:1d.0: AER: TLP Header: 34000000 0a000052 00000000 00000000 > [ 606.528079] pcieport 0000:00:1d.0: AER: Error of this Agent is reported first > [ 606.528098] pcieport 0000:04:01.0: PCIe Bus Error: severity=Uncorrected (Non-Fatal), type=Transaction Layer, (Requester ID) > [ 606.528101] pcieport 0000:04:01.0: device [8086:1136] error status/mask=00300000/00000000 > [ 606.528105] pcieport 0000:04:01.0: [20] UnsupReq (First) > [ 606.528107] pcieport 0000:04:01.0: [21] ACSViol > [ 606.528110] pcieport 0000:04:01.0: AER: TLP Header: 34000000 04000052 00000000 00000000 > [ 606.528187] thunderbolt 0000:05:00.0: AER: can't recover (no error_detected callback) > [ 606.558729] ------------[ cut here ]------------ > [ 606.558729] igc 0000:38:00.0: disabling already-disabled device > [ 606.558738] WARNING: CPU: 0 PID: 209 at drivers/pci/pci.c:2248 pci_disable_device+0xf6/0x150 > [ 606.558743] Modules linked in: rfcomm ccm cmac algif_hash algif_skcipher af_alg usbhid bnep snd_hda_codec_hdmi snd_ctl_led snd_hda_codec_realtek joydev snd_hda_codec_generic ledtrig_audio binfmt_misc snd_sof_pci_intel_tgl snd_sof_intel_hda_common snd_soc_acpi_intel_match snd_soc_acpi snd_soc_hdac_hda snd_sof_pci snd_sof_xtensa_dsp x86_pkg_temp_thermal snd_sof_intel_hda_mlink intel_powerclamp snd_sof_intel_hda snd_sof snd_sof_utils snd_hda_ext_core snd_soc_core snd_compress snd_hda_intel coretemp snd_intel_dspcfg snd_hda_codec snd_hwdep kvm_intel snd_hda_core iwlmvm nls_iso8859_1 i915 snd_pcm kvm mac80211 crct10dif_pclmul crc32_pclmul i2c_algo_bit uvcvideo ghash_clmulni_intel snd_seq mei_pxp drm_buddy videobuf2_vmalloc sch_fq_codel sha512_ssse3 libarc4 aesni_intel mei_hdcp videobuf2_memops btusb uvc crypto_simd drm_display_helper snd_seq_device btrtl videobuf2_v4l2 cryptd snd_timer intel_rapl_msr btbcm drm_kms_helper videodev iwlwifi snd btintel rapl input_leds wmi_bmof hid_senso r_rotation btmtk hid_sensor_accel_3d > [ 606.558778] hid_sensor_gyro_3d hid_sensor_als syscopyarea videobuf2_common intel_cstate serio_raw soundcore bluetooth hid_sensor_trigger thunderbolt sysfillrect cfg80211 mc mei_me industrialio_triggered_buffer sysimgblt processor_thermal_device_pci hid_sensor_iio_common hid_multitouch ecdh_generic processor_thermal_device kfifo_buf cec 8250_dw mei ecc processor_thermal_rfim industrialio rc_core processor_thermal_mbox ucsi_acpi processor_thermal_rapl ttm typec_ucsi intel_rapl_common msr typec video int3403_thermal int340x_thermal_zone int3400_thermal intel_hid wmi acpi_pad acpi_thermal_rel sparse_keymap acpi_tad mac_hid parport_pc ppdev lp parport drm ramoops reed_solomon efi_pstore ip_tables x_tables autofs4 hid_sensor_custom hid_sensor_hub intel_ishtp_hid spi_pxa2xx_platform hid_generic dw_dmac dw_dmac_core rtsx_pci_sdmmc e1000e i2c_i801 igc nvme i2c_smbus intel_lpss_pci rtsx_pci intel_ish_ipc nvme_core intel_lpss xhci_pci i2c_hid_acpi intel_ishtp idma64 xhci_pci_renesas i2c_h id hid pinctrl_alderlake > [ 606.558809] CPU: 0 PID: 209 Comm: irq/124-aerdrv Not tainted 6.4.0-rc7+ #119 > [ 606.558811] Hardware name: HP HP ZBook Fury 16 G9 Mobile Workstation PC/89C6, BIOS U96 Ver. 01.07.01 04/06/2023 > [ 606.558812] RIP: 0010:pci_disable_device+0xf6/0x150 > [ 606.558814] Code: 4d 85 e4 75 07 4c 8b a3 d0 00 00 00 48 8d bb d0 00 00 00 e8 5c f5 1f 00 4c 89 e2 48 c7 c7 f8 e6 37 ae 48 89 c6 e8 9a 3e 86 ff <0f> 0b e9 3c ff ff ff 48 8d 55 e6 be 04 00 00 00 48 89 df e8 62 0b > [ 606.558815] RSP: 0018:ffffa70040a4fca0 EFLAGS: 00010246 > [ 606.558816] RAX: 0000000000000000 RBX: ffff8ac8434b2000 RCX: 0000000000000000 > [ 606.558817] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000 > [ 606.558818] RBP: ffffa70040a4fcc0 R08: 0000000000000000 R09: 0000000000000000 > [ 606.558818] R10: 0000000000000000 R11: 0000000000000000 R12: ffff8ac843435dd0 > [ 606.558818] R13: ffff8ac84277c000 R14: 0000000000000001 R15: ffff8ac8434b2150 > [ 606.558819] FS: 0000000000000000(0000) GS:ffff8acbd6a00000(0000) knlGS:0000000000000000 > [ 606.558820] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ 606.558821] CR2: 00007f9740ba28e8 CR3: 00000001eb43a000 CR4: 0000000000f50ef0 > [ 606.558822] PKRU: 55555554 > [ 606.558822] Call Trace: > [ 606.558823] > [ 606.558825] ? show_regs+0x76/0x90 > [ 606.558828] ? pci_disable_device+0xf6/0x150 > [ 606.558830] ? __warn+0x91/0x160 > [ 606.558832] ? pci_disable_device+0xf6/0x150 > [ 606.558834] ? report_bug+0x1bf/0x1d0 > [ 606.558838] nvme nvme0: 24/0/0 default/read/poll queues > [ 606.558837] ? handle_bug+0x46/0x90 > [ 606.558841] ? exc_invalid_op+0x1d/0x90 > [ 606.558843] ? asm_exc_invalid_op+0x1f/0x30 > [ 606.558846] ? pci_disable_device+0xf6/0x150 > [ 606.558849] igc_io_error_detected+0x40/0x70 [igc] > [ 606.558857] report_error_detected+0xdb/0x1d0 > [ 606.558860] ? __pfx_report_normal_detected+0x10/0x10 > [ 606.558862] report_normal_detected+0x1a/0x30 > [ 606.558864] pci_walk_bus+0x78/0xb0 > [ 606.558866] pcie_do_recovery+0xba/0x340 > [ 606.558868] ? __pfx_aer_root_reset+0x10/0x10 > [ 606.558870] aer_process_err_devices+0x168/0x220 > [ 606.558871] aer_isr+0x1d3/0x1f0 > [ 606.558874] ? __pfx_irq_thread_fn+0x10/0x10 > [ 606.558876] irq_thread_fn+0x29/0x70 > [ 606.558877] irq_thread+0xee/0x1c0 > [ 606.558878] ? __pfx_irq_thread_dtor+0x10/0x10 > [ 606.558879] ? __pfx_irq_thread+0x10/0x10 > [ 606.558880] kthread+0xf8/0x130 > [ 606.558882] ? __pfx_kthread+0x10/0x10 > [ 606.558884] ret_from_fork+0x29/0x50 > [ 606.558887] > [ 606.558887] ---[ end trace 0000000000000000 ]--- > [ 606.570223] i915 0000:00:02.0: [drm] GT0: HuC: authenticated! > [ 606.570228] i915 0000:00:02.0: [drm] GT0: GUC: submission disabled > [ 606.570231] i915 0000:00:02.0: [drm] GT0: GUC: SLPC disabled > [ 606.663042] xhci_hcd 0000:39:00.0: AER: can't recover (no error_detected callback) > [ 606.663111] pcieport 0000:00:1d.0: AER: device recovery failed > [ 606.721642] iwlwifi 0000:00:14.3: WFPM_UMAC_PD_NOTIFICATION: 0x1f > [ 606.721677] iwlwifi 0000:00:14.3: WFPM_LMAC2_PD_NOTIFICATION: 0x1f > [ 606.721687] iwlwifi 0000:00:14.3: WFPM_AUTH_KEY_0: 0x90 > [ 606.721698] iwlwifi 0000:00:14.3: CNVI_SCU_SEQ_DATA_DW9: 0x0 > [ 606.842877] usb 1-8: reset high-speed USB device number 3 using xhci_hcd > [ 607.048340] genirq: Flags mismatch irq 164. 00000000 (enp56s0) vs. 00000000 (enp56s0) > [ 607.050313] ------------[ cut here ]------------ > ... > [ 609.064160] igc 0000:38:00.0 enp56s0: Register Dump > [ 609.064167] igc 0000:38:00.0 enp56s0: Register Name Value > [ 609.064181] igc 0000:38:00.0 enp56s0: CTRL 081c0641 > [ 609.064188] igc 0000:38:00.0 enp56s0: STATUS 40280401 > [ 609.064195] igc 0000:38:00.0 enp56s0: CTRL_EXT 100000c0 > [ 609.064202] igc 0000:38:00.0 enp56s0: MDIC 18017949 > [ 609.064208] igc 0000:38:00.0 enp56s0: ICR 80000010 > [ 609.064214] igc 0000:38:00.0 enp56s0: RCTL 04408022 > [ 609.064232] igc 0000:38:00.0 enp56s0: RDLEN[0-3] 00001000 00001000 00001000 00001000 > [ 609.064251] igc 0000:38:00.0 enp56s0: RDH[0-3] 00000000 00000000 00000000 00000000 > [ 609.064270] igc 0000:38:00.0 enp56s0: RDT[0-3] 000000ff 000000ff 000000ff 000000ff > [ 609.064289] igc 0000:38:00.0 enp56s0: RXDCTL[0-3] 00040808 00040808 00040808 00040808 > [ 609.064308] igc 0000:38:00.0 enp56s0: RDBAL[0-3] ffc62000 fff6b000 fff6c000 fff6d000 > [ 609.064326] igc 0000:38:00.0 enp56s0: RDBAH[0-3] 00000000 00000000 00000000 00000000 > [ 609.064333] igc 0000:38:00.0 enp56s0: TCTL a50400fa > [ 609.064351] igc 0000:38:00.0 enp56s0: TDBAL[0-3] fff6d000 ffcdf000 ffce0000 ffce1000 > [ 609.064369] igc 0000:38:00.0 enp56s0: TDBAH[0-3] 00000000 00000000 00000000 00000000 > [ 609.064387] igc 0000:38:00.0 enp56s0: TDLEN[0-3] 00001000 00001000 00001000 00001000 > [ 609.064405] igc 0000:38:00.0 enp56s0: TDH[0-3] 00000000 00000000 00000000 00000000 > [ 609.064423] igc 0000:38:00.0 enp56s0: TDT[0-3] 00000004 00000000 00000000 00000000 > [ 609.064441] igc 0000:38:00.0 enp56s0: TXDCTL[0-3] 00100108 00100108 00100108 00100108 > [ 609.064445] igc 0000:38:00.0 enp56s0: Reset adapter > > The issue is that the PTM requests are sending before driver resumes the > device. Since the issue can also be observed on Windows, it's quite > likely a firmware/hardwar limitation. > > So avoid resetting the device if it's not resumed. Once the device is > fully resumed, the device can work normally. > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=216850 > Signed-off-by: Kai-Heng Feng > --- Feel free to add my: Acked-by: Vinicius Costa Gomes After the comments are addressed. Cheers, -- Vinicius _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan