From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kurt Kanzenbach Date: Wed, 27 Jan 2021 10:03:53 +0100 Subject: [Intel-wired-lan] [PATCH net-next v3 5/8] igc: Avoid TX Hangs because long cycles In-Reply-To: <20210126000228.gpyh3rrp662wysit@skbuf> References: <20210122224453.4161729-1-vinicius.gomes@intel.com> <20210122224453.4161729-6-vinicius.gomes@intel.com> <20210126000228.gpyh3rrp662wysit@skbuf> Message-ID: <87czxqda4m.fsf@kurt> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On Tue Jan 26 2021, Vladimir Oltean wrote: > On Fri, Jan 22, 2021 at 02:44:50PM -0800, Vinicius Costa Gomes wrote: >> Avoid possible TX Hangs caused by using long Qbv cycles. In some >> cases, using long cycles (more than 1 second) can cause transmissions >> to be blocked for that time. As the TX Hang timeout is close to 1 >> second, we may need to reduce the cycle time to something more >> reasonable: the value chosen is 1ms. >> >> Signed-off-by: Vinicius Costa Gomes >> --- > > Don't you want this patch to go to 'net' and be backported? I'm wondering about this patch as well. Is this fix related to frame preemption? If I understand the code correctly the 1sec is a dummy cycle and all queues are open. How should Tx hang then? Thanks, Kurt -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 832 bytes Desc: not available URL: