From: Andrew Lunn <andrew@lunn.ch>
To: Pawel Chmielewski <pawel.chmielewski@intel.com>
Cc: aelior@marvell.com, manishc@marvell.com, netdev@vger.kernel.org,
intel-wired-lan@lists.osuosl.org, "Greenwalt,
Paul" <paul.greenwalt@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2 2/9] ethtool: Add forced speed to supported link modes maps
Date: Sun, 3 Sep 2023 16:00:57 +0200 [thread overview]
Message-ID: <87ea2635-c0b3-4de4-bc65-cbc33a0d5814@lunn.ch> (raw)
In-Reply-To: <ZPCQ5DNU8k8mfAct@baltimore>
> Let me check if I understand correctly- is that what was sent with the
> v3 [1] , with the initialization helper (ethtool_forced_speed_maps_init)
> and the structure map in the ethtool code? Or do you have another helper
> in mind?
Sorry for the late reply, been on vacation.
The main thing is you try to reuse the table:
static const struct phy_setting settings[] = {}
If you can build your helper on top of phy_lookup_setting() even
better. You don't need a phy_device to use those.
Andrew
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-09-03 14:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-19 9:39 [Intel-wired-lan] [PATCH iwl-next v2 2/9] ethtool: Add forced speed to supported link modes maps Paul Greenwalt
2023-08-20 14:45 ` Simon Horman
2023-08-20 17:29 ` Greenwalt, Paul
2023-08-20 18:54 ` Andrew Lunn
2023-08-20 19:20 ` Greenwalt, Paul
2023-08-23 17:56 ` Pawel Chmielewski
2023-08-23 18:09 ` Jacob Keller
2023-08-23 20:58 ` Andrew Lunn
2023-08-25 13:19 ` Alexander Lobakin
2023-08-25 13:47 ` Andrew Lunn
2023-08-25 13:57 ` Alexander Lobakin
2023-08-31 13:08 ` Pawel Chmielewski
2023-09-03 14:00 ` Andrew Lunn [this message]
2023-09-04 15:27 ` Pawel Chmielewski
2023-09-14 14:27 ` Pawel Chmielewski
2023-09-15 13:41 ` Alexander Lobakin
2023-09-15 13:58 ` Andrew Lunn
2023-09-15 13:53 ` Andrew Lunn
2023-08-21 13:00 ` Alexander Lobakin
2023-08-24 10:18 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ea2635-c0b3-4de4-bc65-cbc33a0d5814@lunn.ch \
--to=andrew@lunn.ch \
--cc=aelior@marvell.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=paul.greenwalt@intel.com \
--cc=pawel.chmielewski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox