From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77BB3C10DCE for ; Fri, 1 Dec 2023 13:31:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 0959F60BAF; Fri, 1 Dec 2023 13:31:55 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 0959F60BAF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1701437515; bh=TwRrd9wPYHSEhgI8RiPICh9TSEP3I+6AUvVWG6Fd8/o=; h=From:To:In-Reply-To:References:Date:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=GW80VaQHmlqSEC3+rURs6jWaXt9zgBx/b/semkHWhLn5cIhe3vd/zrK97Ur8Rd0Gw i5Gj0AL017oDH8/6np76FmrneNAwXI+mbDNBtVDohmsllXNVGU/IaOEZv+oXzpjr2T IHNQGAnyXtkkjICwgnOx9T8rwbg3tT7zuviC+mXGnUjYqpCLsaSfpOatGRnIdyBP/s Jk02wJ7haKRP+qJxipH8IOiEha8c56Ql8035S3w8sXi2u5sZ2jUNPhyBu1e+gTgXmm jaxb2FUPPUAEoPYg5TD9q9oLKtm3jZJyJqNiS9vhvs+EIuPhw4JJlxyojDfz+hFxFO V5OELC/T23Pvw== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YIDtZcNohmFf; Fri, 1 Dec 2023 13:31:54 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 05BDC6FA15; Fri, 1 Dec 2023 13:31:53 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 05BDC6FA15 Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id D694C1BF5E9 for ; Fri, 1 Dec 2023 13:31:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id AE27942143 for ; Fri, 1 Dec 2023 13:31:51 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org AE27942143 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NeMdcp6Ayorw for ; Fri, 1 Dec 2023 13:31:51 +0000 (UTC) Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by smtp4.osuosl.org (Postfix) with ESMTPS id 09B3942142 for ; Fri, 1 Dec 2023 13:31:50 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 09B3942142 From: Kurt Kanzenbach To: Suman Ghosh , Jesse Brandeburg , Tony Nguyen , Vinicius Costa Gomes In-Reply-To: References: <20231201075043.7822-1-kurt@linutronix.de> <20231201075043.7822-2-kurt@linutronix.de> Date: Fri, 01 Dec 2023 14:31:45 +0100 Message-ID: <87fs0m2gn2.fsf@kurt> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1701437507; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UPBgS6HkYRkOkv21t9MfxwD13qsaPAeJ9zmSlmunmb4=; b=nHLOwjK6VqSE6j91L4KEZqxKl/P4Wu8TNhM5ZWgCihkFT9MGhkiuJRZji8e9B489+jkma4 yYTSFXhEF3xMzpRAhm2Noy9EbTbthBVzGYgrt+gtN+KSf9F7WBLWBKTqBBbjhSsUtSXKhV Ci7cjxcifQzxDf3RhqCQoOdfg5dsHYKIEIl2tAxdXZtSUrVPPgw7iF0Igl8npmadtCNFxx nkaHUHwz9c0I9nwgMfORElqfP0lSwf6XBxtSglfb3L8pdvJpjEC+cqeWk1hHUOIfqY0D0P 19oL9D0cTO/J+1D/G/zYbTzHOQ84a8PYhbwfOhxk9ji2IX6W0ghmBH9DSi1T5w== X-Mailman-Original-DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1701437507; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UPBgS6HkYRkOkv21t9MfxwD13qsaPAeJ9zmSlmunmb4=; b=7o4X1CACoAzwuWvHTrfkLltCTGL/Mq9vwEQevdUG3xY1yDVmpJC8Y5J/lhndAtpT5GsQS2 a+vODSD9H8qbSCBg== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.a=rsa-sha256 header.s=2020 header.b=nHLOwjK6; dkim=pass header.d=linutronix.de header.i=@linutronix.de header.a=ed25519-sha256 header.s=2020e header.b=7o4X1CAC Subject: Re: [Intel-wired-lan] [EXT] [PATCH iwl-net v2 1/2] igc: Report VLAN EtherType matching back to user X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "netdev@vger.kernel.org" , Eric Dumazet , "intel-wired-lan@lists.osuosl.org" , Jakub Kicinski , Paolo Abeni , "David S. Miller" Content-Type: multipart/mixed; boundary="===============1897736211759465046==" Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" --===============1897736211759465046== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Hi Suman, On Fri Dec 01 2023, Suman Ghosh wrote: > Hi Kurt, > > >>+ if (rule->filter.match_flags & IGC_FILTER_FLAG_VLAN_ETYPE) { >>+ fsp->flow_type |= FLOW_EXT; >>+ fsp->h_ext.vlan_etype = rule->filter.vlan_etype; >>+ fsp->m_ext.vlan_etype = ETHER_TYPE_FULL_MASK; > [Suman] User can provide mask for vlan-etype as well. Why not take > that rather than hard coding it? I checked you are already doing the > same for TCI in the other patch. Currently the driver allows/supports to match the VLAN EtherType only by full mask. That is different from TCI, where two different mask values are possible. Thanks, Kurt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJHBAEBCgAxFiEEvLm/ssjDfdPf21mSwZPR8qpGc4IFAmVp4EETHGt1cnRAbGlu dXRyb25peC5kZQAKCRDBk9HyqkZzgiT6D/sGHAgkvZqoH10WUoVnaxUvE7W0RoEN h6+7WS0BMVPOWK6dvsvP8QMm9ECJrGpI+BrA4StfbyJci/n2anUeYDPf67ozlInJ Cw106cjEsIVMxQumY5YJKm/1/Hg3o2aZ1XzVRG5WIjDHJxn7A0qXSZ4FjWZxXEtu QJ4JsfY7w7A7YAXJHOqXebqlc36OMdxtCjRufH7GDNT0aZHK1JXovOW8/nf70/7+ zz/3ygJvu7691hr+mUazQ0DB6FXFol41EjlITxumdqhdFYYF1Fts0uZ+g0wGdOVn lAVZ5ss62dTQ3tnedxrADoU65U5LXqiGWg2Zp+R2mwvoUoyzRSmiwG1kq4VF5hWW fV4xtxLNEUCW1ebQ5OLwYgIBrzGpaOrhnvW1IwRHR9OPa+qyTL8ENd6oMCfQICP2 aA0yrzGhNSy4Ew0P8XFFTfN21+FzziarG8iCtg5TYl6ev4hIfPSdLAKtEC8MbNZD qB7c10GgGigEQIoPrtFrqSkd1LN/0hFUzPWJTWx/4RSNa18nZrHSHA5JxgsLX0Pp l/qZChqVWrgphTRCjWvMysVF1DUPa3tkLlRqotACau0AxTXk2eZwFflmVK8AmQoN Zx2Z3yNpvku3X8GvLHbTcSGqiicEgzCOMGAj/gU+jFvJ1fmx4JVkpwcDoHB0KTsV E623CKidIznuOg== =aGjs -----END PGP SIGNATURE----- --=-=-=-- --===============1897736211759465046== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan --===============1897736211759465046==--