From: Kurt Kanzenbach <kurt@linutronix.de>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH RFC net] igb: Fix XDP with PTP enabled
Date: Tue, 13 Apr 2021 19:21:00 +0200 [thread overview]
Message-ID: <87fszuyubn.fsf@kurt> (raw)
In-Reply-To: <CAKgT0UekqPNQxV6PzpEeis69z3e3YNcaFyot=nD7w26hLxPX2Q@mail.gmail.com>
On Tue Apr 13 2021, Alexander Duyck wrote:
> On Mon, Apr 12, 2021 at 7:29 AM Jesper Dangaard Brouer
> <brouer@redhat.com> wrote:
>> > +ktime_t igb_ptp_rx_pktstamp(struct igb_q_vector *q_vector, void *va)
>> > {
>> > struct igb_adapter *adapter = q_vector->adapter;
>> > + struct skb_shared_hwtstamps ts;
>> > __le64 *regval = (__le64 *)va;
>> > int adjust = 0;
>> >
>> > if (!(adapter->ptp_flags & IGB_PTP_ENABLED))
>> > - return IGB_RET_PTP_DISABLED;
>> > + return 0;
>> >
>> > /* The timestamp is recorded in little endian format.
>> > * DWORD: 0 1 2 3
>> > @@ -888,10 +887,9 @@ int igb_ptp_rx_pktstamp(struct igb_q_vector *q_vector, void *va,
>> >
>> > /* check reserved dwords are zero, be/le doesn't matter for zero */
>> > if (regval[0])
>> > - return IGB_RET_PTP_INVALID;
>> > + return 0;
>> >
>
> One thing that needs to be cleaned up in the patch is that if it is
> going to drop these return values it should probably drop the defines
> for them since I don't think they are used anywhere else.
Yes, of course. I'll clean it up before sending a non RFC version.
Thanks,
Kurt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20210413/d3b3f8ec/attachment.asc>
next prev parent reply other threads:[~2021-04-13 17:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 10:17 [Intel-wired-lan] [PATCH RFC net] igb: Fix XDP with PTP enabled Kurt Kanzenbach
2021-04-12 14:28 ` Jesper Dangaard Brouer
2021-04-13 7:34 ` Kurt Kanzenbach
2021-04-13 15:25 ` Alexander Duyck
2021-04-13 17:21 ` Kurt Kanzenbach [this message]
2021-06-02 10:49 ` Penigalapati, Sandeep
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fszuyubn.fsf@kurt \
--to=kurt@linutronix.de \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox