From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BAFFFC52D6F for ; Mon, 19 Aug 2024 14:23:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 64E5660818; Mon, 19 Aug 2024 14:23:35 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id B1Nyfr5wbJVc; Mon, 19 Aug 2024 14:23:33 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 999FC60801 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1724077413; bh=+mxhW/AMCmI2oaiMdzAW2dtIm1Ckb87i0ukk7+cIY4I=; h=From:To:In-Reply-To:References:Date:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=yHd1IQbtWNsgyq6uqNebLtO9Nue73L9SpIlh9YStgbLjHKeMsu0MzFEEZBvilp/lq G+vaCazoCP/G2TIvKaAMVzg2jvHkjiHoHt3MVaQPoznsPUMCttak2Nd1iVbl4aelaD c9QyiX5/QAjukUQ1Qic6gP8drmSLPsB9NA55pCdBGbW6I3Jsh2GfJMxptpsPLxm5ww BSXoJwk3qkssHJoCbVqgZHkEvwXqNJKPsrZoYfsYvAIUfH8tmWTC/LEmVaTdop8oQJ 9XNxnYm4TAYI2g8+TlSnbG/g8Xp6S3vP9twRRHRPeJuREWmDpzDDQdmVJEKg2vmdAK fWPLsXXGBXaGw== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 999FC60801; Mon, 19 Aug 2024 14:23:33 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 8ADD41BF3BC for ; Mon, 19 Aug 2024 14:23:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 836AB40491 for ; Mon, 19 Aug 2024 14:23:32 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id Qt7ozOCZmpo3 for ; Mon, 19 Aug 2024 14:23:31 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=193.142.43.55; helo=galois.linutronix.de; envelope-from=kurt@linutronix.de; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 75B7D4048F DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 75B7D4048F Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by smtp4.osuosl.org (Postfix) with ESMTPS id 75B7D4048F for ; Mon, 19 Aug 2024 14:23:31 +0000 (UTC) From: Kurt Kanzenbach To: Maciej Fijalkowski In-Reply-To: References: <20240711-b4-igb_zero_copy-v6-0-4bfb68773b18@linutronix.de> <20240711-b4-igb_zero_copy-v6-2-4bfb68773b18@linutronix.de> Date: Mon, 19 Aug 2024 16:23:27 +0200 Message-ID: <87jzgc8ucg.fsf@kurt.kurt.home> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1724077409; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+mxhW/AMCmI2oaiMdzAW2dtIm1Ckb87i0ukk7+cIY4I=; b=iUrS1NI9pTD61ICXAO/4wBIl74n5KrnCcoLLIRJtqExUDJFbD1TH94gwxGx2c/gXnkFKqJ AXLGlogabypH0IYEP8XLzSgI1K/taJz+aoG5649kccSCcvGzzEpvzFXTJ5Efk9UBmcD53H D4mzhDCo9AI0tpOgrP3VCpmIlmbBICmHQP7l7P6DXr6CLUeHDfeYWaTeoU9LaM6eTbK4nA UtSdON26Ea2SPv9tmmdTZjMldDHUsIJnCyyqsBVFTijffukQLhZNp+gYz/Gcrl+0XaomQd Yzz9vLdWcAWANhhVOU5CbZRwl5Wgb+pKci/BqLD59bVXwrNcUL4o4U2l1c546g== X-Mailman-Original-DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1724077409; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+mxhW/AMCmI2oaiMdzAW2dtIm1Ckb87i0ukk7+cIY4I=; b=edGRjFn6pqNQ9iqMPbs5B4pEJsRIwpS4DDzyET7tE6SMA5PZz69RByR20WOQtkjZtEu3Ot AXxiyks0NnqfBYBg== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=none dis=none) header.from=linutronix.de X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=linutronix.de header.i=@linutronix.de header.a=rsa-sha256 header.s=2020 header.b=iUrS1NI9; dkim=pass header.d=linutronix.de header.i=@linutronix.de header.a=ed25519-sha256 header.s=2020e header.b=edGRjFn6 Subject: Re: [Intel-wired-lan] [PATCH iwl-next v6 2/6] igb: Remove static qualifiers X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jesper Dangaard Brouer , Daniel Borkmann , Sriram Yagnaraman , Przemek Kitszel , Richard Cochran , John Fastabend , Alexei Starovoitov , Sriram Yagnaraman , Benjamin Steinke , Eric Dumazet , netdev@vger.kernel.org, Tony Nguyen , intel-wired-lan@lists.osuosl.org, Jakub Kicinski , bpf@vger.kernel.org, Paolo Abeni , "David S. Miller" , Sebastian Andrzej Siewior Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Mon Aug 19 2024, Maciej Fijalkowski wrote: > On Fri, Aug 16, 2024 at 11:24:01AM +0200, Kurt Kanzenbach wrote: >> From: Sriram Yagnaraman >>=20 >> Remove static qualifiers on the following functions to be able to call >> from XSK specific file that is added in the later patches: >> - igb_xdp_tx_queue_mapping() >> - igb_xdp_ring_update_tail() >> - igb_clean_tx_ring() >> - igb_clean_rx_ring() >> - igb_xdp_xmit_back() >> - igb_process_skb_fields() > > How about inlining some of these that are small enough? > > - igb_xdp_tx_queue_mapping() > - igb_xdp_ring_update_tail() Will do. Thanks, Kurt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJHBAEBCgAxFiEEvLm/ssjDfdPf21mSwZPR8qpGc4IFAmbDVV8THGt1cnRAbGlu dXRyb25peC5kZQAKCRDBk9HyqkZzgowCD/0ep7WJYeDlyu9YzP+Hs3hojDR8zDf7 bZuuR+QZbpX2BFP7pa15MaaRzcIRumkqC4gIse67H++iEBedii9FmntU0LyeaMS/ p6ThB/E6JY7+iCDJfTCTXNJ5A4uf4g8y6qLtizLWjsNhUwKW5HeiT2h9eHDYnJAU mo9KRYvjG3EFMmskiO7fxzhF5cobwoTgrIR2gOH16pwqM5B3j2rbIRjwNIriYbo5 Q8FQBqXWPMYwxSmY1SEiHOQ5LEp8uM9VyT244UrqT24rCENLO5xKjzyFfx3lma+s xRgQCtYmmTQhBqC0ujozgiB50TB7yO8PCn/NEfZDEEP8sz8F3gMBGa1YFbpq/m0J Il8hatVhxOfMBVvseDhEW0wgEZQ/zW25YvIP1C3z/hxAz0u/RYaaioRa+HdRlws2 zp7gtqo8E+jzKG7kK48i6CSikxBI/aauOZQ8ihg76+cBy7SVz7Veeq6WmQ/brJX+ UArZJQZd37cNjDtZALxgvEVAXZgyogXEdfSYiBdfGHKF4Z33i0dpr83tUBi6gWOm 9824+CM91+qJxCbl25HyAC/OPrS0YOlUxusoIxDYiRQbDOpUgw79YjqclpVhn9oi Z0ry80HGjTeleQ3pg7Xp9JSL1nlofr3OM3mTPpkah7MHhIUhLc7zA1P/rWMFsTXK Uc+jR5/+VjJ0yA== =1bJz -----END PGP SIGNATURE----- --=-=-=--