From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [net] igb/igc: use ktime accessors for skb->tstamp
Date: Thu, 07 Nov 2019 11:10:44 -0800 [thread overview]
Message-ID: <87k18btscr.fsf@linux.intel.com> (raw)
In-Reply-To: <20191106171823.30554-1-jacob.e.keller@intel.com>
Jacob Keller <jacob.e.keller@intel.com> writes:
> When implementing launch time support in the igb and igc drivers, the
> skb->tstamp value is assumed to be a s64, but it's declared as a ktime_t
> value.
>
> Although ktime_t is typedef'd to s64 it wasn't always, and the kernel
> provides accessors for ktime_t values.
>
> Use the ktime_to_timespec64 and ktime_set accessors instead of directly
> assuming that the variable is always an s64.
>
> This improves portability if the code is ever moved to another kernel
> version, or if the definition of ktime_t ever changes again in the
> future.
>
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> ---
Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
prev parent reply other threads:[~2019-11-07 19:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 17:18 [Intel-wired-lan] [net] igb/igc: use ktime accessors for skb->tstamp Jacob Keller
2019-11-07 19:10 ` Vinicius Costa Gomes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k18btscr.fsf@linux.intel.com \
--to=vinicius.gomes@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox