From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-pci@vger.kernel.org
Cc: intel-wired-lan@lists.osuosl.org,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Lukas Wunner" <lukas@wunner.de>,
"Tony Nguyen" <anthony.l.nguyen@intel.com>,
"Przemek Kitszel" <przemyslaw.kitszel@intel.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Saeed Mahameed" <saeedm@nvidia.com>,
"Leon Romanovsky" <leon@kernel.org>,
"Tariq Toukan" <tariqt@nvidia.com>,
"Mark Bloch" <mbloch@nvidia.com>,
"Richard Cochran" <richardcochran@gmail.com>,
"Andy Shevchenko" <andriy.shevchenko@intel.com>,
"Vitaly Lifshits" <vitaly.lifshits@intel.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Dima Ruinskiy" <dima.ruinskiy@intel.com>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>
Subject: Re: [Intel-wired-lan] [PATCH 3/5] igc: Don't reset the hardware on suspend path
Date: Tue, 24 Feb 2026 13:08:49 -0800 [thread overview]
Message-ID: <87ldgh7sta.fsf@intel.com> (raw)
In-Reply-To: <20260224111044.3487873-4-mika.westerberg@linux.intel.com>
Mika Westerberg <mika.westerberg@linux.intel.com> writes:
> Commit c01163dbd1b8 ("PCI/PM: Always disable PTM for all devices during
> suspend") made the PCI core to suspend (disable) PTM before driver
> suspend hooks are called. In case of igc what happens is that on suspend
> path PCI core calls pci_suspend_ptm() then igc suspend hook that calls
> igc_down() that ends up calling igc_ptp_reset() (which according to the
> comment is actually needed for re-enabling the device). Anyways that
> function also poll IGC_PTM_STAT that will end up timing out because PTM
> is already disabled:
>
> [ 160.716119] igc 0000:03:00.0 enp3s0: Timeout reading IGC_PTM_STAT register
>
> There should be no reason resetting the hardware on suspend path so fix
> this by avoiding the reset.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Cheers,
--
Vinicius
next prev parent reply other threads:[~2026-02-24 21:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 11:10 [Intel-wired-lan] [PATCH 0/5] PCI / igc: Improvements related to PTM enabling Mika Westerberg
2026-02-24 11:10 ` [Intel-wired-lan] [PATCH 1/5] igc: Call netif_queue_set_napi() with rntl locked Mika Westerberg
2026-02-24 21:07 ` Vinicius Costa Gomes
2026-03-09 10:32 ` Dahan, AvigailX
2026-02-24 11:10 ` [Intel-wired-lan] [PATCH 2/5] igc: Let the PCI core deal with the PM resume flow Mika Westerberg
2026-02-24 16:58 ` Bjorn Helgaas
2026-02-25 12:26 ` Mika Westerberg
2026-02-25 12:28 ` Mika Westerberg
2026-02-25 23:56 ` Vinicius Costa Gomes
2026-02-26 11:12 ` Mika Westerberg
2026-02-24 21:08 ` Vinicius Costa Gomes
2026-03-09 10:37 ` Dahan, AvigailX
2026-02-24 11:10 ` [Intel-wired-lan] [PATCH 3/5] igc: Don't reset the hardware on suspend path Mika Westerberg
2026-02-24 21:08 ` Vinicius Costa Gomes [this message]
2026-03-09 10:39 ` Dahan, AvigailX
2026-02-24 11:10 ` [Intel-wired-lan] [PATCH 4/5] PCI/PTM: Drop granularity parameter from pci_enable_ptm() Mika Westerberg
2026-02-24 22:26 ` Jacob Keller
2026-03-09 10:50 ` Dahan, AvigailX
2026-02-24 11:10 ` [Intel-wired-lan] [PATCH 5/5] PCI/PTM: Do not enable PTM automatically for Root and Switch Upstream Ports Mika Westerberg
2026-03-09 10:54 ` Dahan, AvigailX
2026-02-24 17:13 ` [Intel-wired-lan] [PATCH 0/5] PCI / igc: Improvements related to PTM enabling Bjorn Helgaas
2026-02-25 12:27 ` Mika Westerberg
2026-02-24 22:28 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ldgh7sta.fsf@intel.com \
--to=vinicius.gomes@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=andriy.shevchenko@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=dima.ruinskiy@intel.com \
--cc=edumazet@google.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=leon@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mbloch@nvidia.com \
--cc=mika.westerberg@linux.intel.com \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=richardcochran@gmail.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=vitaly.lifshits@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox