From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next-queue PATCH v3 8/8] igb: Add support for adding offloaded clsflower filters
Date: Wed, 07 Mar 2018 14:24:04 -0800 [thread overview]
Message-ID: <87tvtrzfqz.fsf@intel.com> (raw)
In-Reply-To: <20180307114831.16b1788b@cakuba.netronome.com>
Hi,
Jakub Kicinski <kubakici@wp.pl> writes:
> On Tue, 6 Mar 2018 17:29:57 -0800, Vinicius Costa Gomes wrote:
>> This allows filters added by tc-flower and specifying MAC addresses,
>> Ethernet types, and the VLAN priority field, to be offloaded to the
>> controller.
>>
>> This reuses most of the infrastructure used by ethtool, but clsflower
>> filters are kept in a separated list, so they are invisible to
>> ethtool.
>>
>> Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
>
> LGTM, thanks!
>
>> + NL_SET_ERR_MSG(extack,
>
> One nit: consider using NL_SET_ERR_MSG_MOD to prefix the message with
> driver name.
Sure thing. Will send a v4 with this shortly.
Cheers,
--
Vinicius
prev parent reply other threads:[~2018-03-07 22:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 1:29 [Intel-wired-lan] [next-queue PATCH v3 0/8] igb: offloading of receive filters Vinicius Costa Gomes
2018-03-07 1:29 ` [Intel-wired-lan] [next-queue PATCH v3 1/8] igb: Fix not adding filter elements to the list Vinicius Costa Gomes
2018-03-07 1:29 ` [Intel-wired-lan] [next-queue PATCH v3 2/8] igb: Fix queue selection on MAC filters on i210 and i211 Vinicius Costa Gomes
2018-03-07 1:29 ` [Intel-wired-lan] [next-queue PATCH v3 3/8] igb: Enable the hardware traffic class feature bit for igb models Vinicius Costa Gomes
2018-03-07 1:29 ` [Intel-wired-lan] [next-queue PATCH v3 4/8] igb: Add support for MAC address filters specifying source addresses Vinicius Costa Gomes
2018-03-07 1:29 ` [Intel-wired-lan] [next-queue PATCH v3 5/8] igb: Enable nfc filters to specify MAC addresses Vinicius Costa Gomes
2018-03-07 1:29 ` [Intel-wired-lan] [next-queue PATCH v3 6/8] igb: Add MAC address support for ethtool nftuple filters Vinicius Costa Gomes
2018-03-07 22:29 ` Brown, Aaron F
2018-03-08 0:10 ` Vinicius Costa Gomes
2018-03-07 1:29 ` [Intel-wired-lan] [next-queue PATCH v3 7/8] igb: Add the skeletons for tc-flower offloading Vinicius Costa Gomes
2018-03-07 1:29 ` [Intel-wired-lan] [next-queue PATCH v3 8/8] igb: Add support for adding offloaded clsflower filters Vinicius Costa Gomes
2018-03-07 19:48 ` Jakub Kicinski
2018-03-07 22:24 ` Vinicius Costa Gomes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvtrzfqz.fsf@intel.com \
--to=vinicius.gomes@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox