From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net-next v1 8/9] igc: Add support for exposing frame preemption stats registers
Date: Mon, 07 Dec 2020 14:29:54 -0800 [thread overview]
Message-ID: <87v9ddz1ul.fsf@intel.com> (raw)
In-Reply-To: <20201205095948.5e0eba28@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
Jakub Kicinski <kuba@kernel.org> writes:
> On Tue, 1 Dec 2020 20:53:24 -0800 Vinicius Costa Gomes wrote:
>> Expose the Frame Preemption counters, so the number of
>> express/preemptible packets can be monitored by userspace.
>>
>> These registers are cleared when read, so the value shown is the
>> number of events that happened since the last read.
>>
>> Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
>
> You mean expose in a register dump? That's not great user experience..
I can agree with that, even after some formatting on the ethtool side:
Preemption statistics:
TX Preemption event counter: 14070
Good TX Preemptable Packets: 201957
Good TX Express Packets: 32031
TX Preempted Packets: 13259
RX Preemption event counter: 0
Good RX Preemptable Packets: 0
Good RX Preempted Packets: 0
Preemption Exception Counter:
OOO_SMDC 0
OOO_FRAME 0
OOO_FRAG 0
MISS_FRAME_FRAG 0
It's less than ideal, but useful for development/debugging.
>
> Are there any stats that the standards mandate?
I just took abother look at the standard, mainly at the MIBs, there are
no statistics related to frame preemption that I could find, only
configuration stuff.
>
> It'd be great if we could come up with some common set and expose them
> via ethtool like the pause frame statistics.
Agreed, will drop this patch, until this common set is agreed upon.
Cheers,
--
Vinicius
next prev parent reply other threads:[~2020-12-07 22:29 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 4:53 [Intel-wired-lan] [PATCH net-next v1 0/9] ethtool: Add support for frame preemption Vinicius Costa Gomes
2020-12-02 4:53 ` [Intel-wired-lan] [PATCH net-next v1 1/9] ethtool: Add support for configuring " Vinicius Costa Gomes
2020-12-03 1:53 ` Jakub Kicinski
2020-12-05 17:43 ` Jakub Kicinski
2020-12-07 22:11 ` Vinicius Costa Gomes
2020-12-07 23:21 ` Jakub Kicinski
2020-12-08 0:24 ` Vinicius Costa Gomes
2020-12-08 0:27 ` Vladimir Oltean
2020-12-08 0:48 ` Jakub Kicinski
2020-12-08 6:22 ` Michal Kubecek
2020-12-02 4:53 ` [Intel-wired-lan] [PATCH net-next v1 2/9] taprio: Add support for frame preemption offload Vinicius Costa Gomes
2020-12-02 4:53 ` [Intel-wired-lan] [PATCH net-next v1 3/9] igc: Set the RX packet buffer size for TSN mode Vinicius Costa Gomes
2020-12-02 4:53 ` [Intel-wired-lan] [PATCH net-next v1 4/9] igc: Only dump registers if configured to dump HW information Vinicius Costa Gomes
2020-12-02 4:53 ` [Intel-wired-lan] [PATCH net-next v1 5/9] igc: Avoid TX Hangs because long cycles Vinicius Costa Gomes
2020-12-02 4:53 ` [Intel-wired-lan] [PATCH net-next v1 6/9] igc: Add support for tuning frame preemption via ethtool Vinicius Costa Gomes
2020-12-05 18:00 ` Jakub Kicinski
2020-12-07 22:15 ` Vinicius Costa Gomes
2020-12-07 23:22 ` Jakub Kicinski
2020-12-02 4:53 ` [Intel-wired-lan] [PATCH net-next v1 7/9] igc: Add support for Frame Preemption offload Vinicius Costa Gomes
2020-12-02 4:53 ` [Intel-wired-lan] [PATCH net-next v1 8/9] igc: Add support for exposing frame preemption stats registers Vinicius Costa Gomes
2020-12-05 17:59 ` Jakub Kicinski
2020-12-07 22:29 ` Vinicius Costa Gomes [this message]
2020-12-02 4:53 ` [Intel-wired-lan] [PATCH net-next v1 9/9] igc: Separate TSN configurations that can be updated Vinicius Costa Gomes
2020-12-05 17:50 ` [Intel-wired-lan] [PATCH net-next v1 0/9] ethtool: Add support for frame preemption Jakub Kicinski
2020-12-07 22:49 ` Vinicius Costa Gomes
2020-12-07 23:12 ` Vladimir Oltean
2020-12-08 0:34 ` Vinicius Costa Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9ddz1ul.fsf@intel.com \
--to=vinicius.gomes@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox