From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next-queue PATCH v5 3/5] net/sched: Introduce Credit Based Shaper (CBS) qdisc
Date: Wed, 11 Oct 2017 14:38:46 -0700 [thread overview]
Message-ID: <87vajlmkk9.fsf@intel.com> (raw)
In-Reply-To: <20171011065809.GB2039@nanopsycho>
Jiri Pirko <jiri@resnulli.us> writes:
[...]
>>+struct tc_cbs_qopt_offload {
>>+ u8 enable;
>>+ s32 queue;
>>+ s32 hicredit;
>>+ s32 locredit;
>>+ s32 idleslope;
>>+ s32 sendslope;
>
> Please introduce the qdisc in one patch, then offload it in second. That
> is what I requested already. 2 patches please.
>
> [...]
Will move these declarations to the offload patch.
>
>
>>+static struct Qdisc_ops cbs_qdisc_ops __read_mostly = {
>>+ .next = NULL,
>
> It is already 0, no need to re-init.
Will fix.
Cheers,
--
Vinicius
next prev parent reply other threads:[~2017-10-11 21:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 0:43 [Intel-wired-lan] [next-queue PATCH v5 0/5] TSN: Add qdisc based config interface for CBS Vinicius Costa Gomes
2017-10-11 0:43 ` [Intel-wired-lan] [next-queue PATCH v5 1/5] net/sched: Check for null dev_queue on create flow Vinicius Costa Gomes
2017-10-11 0:43 ` [Intel-wired-lan] [next-queue PATCH v5 2/5] mqprio: Implement select_queue class_ops Vinicius Costa Gomes
2017-10-11 0:43 ` [Intel-wired-lan] [next-queue PATCH v5 3/5] net/sched: Introduce Credit Based Shaper (CBS) qdisc Vinicius Costa Gomes
2017-10-11 6:58 ` Jiri Pirko
2017-10-11 21:38 ` Vinicius Costa Gomes [this message]
2017-10-11 0:43 ` [Intel-wired-lan] [next-queue PATCH v5 4/5] net/sched: Add support for HW offloading for CBS Vinicius Costa Gomes
2017-10-11 7:07 ` Jiri Pirko
2017-10-11 21:40 ` Vinicius Costa Gomes
2017-10-11 0:44 ` [Intel-wired-lan] [next-queue PATCH v5 5/5] igb: Add support for CBS offload Vinicius Costa Gomes
2017-10-11 3:23 ` [Intel-wired-lan] [next-queue PATCH v5 0/5] TSN: Add qdisc based config interface for CBS David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vajlmkk9.fsf@intel.com \
--to=vinicius.gomes@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox