From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD84BC531DC for ; Fri, 16 Aug 2024 09:56:38 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 683FD60B23; Fri, 16 Aug 2024 09:56:38 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 59x5Ch_RCi5c; Fri, 16 Aug 2024 09:56:37 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org B4A5660B34 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1723802197; bh=jESmOZLP8UWnsshEocvlvp6ISx76GNAGMqVLR6BonUk=; h=From:To:In-Reply-To:References:Date:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=vvMUieiOI8fN2QsFvnCsgcCLO6GwCNjnnd8745eQsmXDtHwQIGZbZuN6sYfqKp0xB Eqi5JHWsEFHPLG9uD7Za8b+lQoITlE45+B0scfmoNWrAmKi40Fnt+pe0Yr7hDhEhw8 kFU+hz2B6LXHeH2BxInYIdQmBvw5xbvqyOvDiI+tp7JGept2uK5ACRB60fzLMAuxQF 8WQTSr+sTddLIqXvE0ZwU/uAosQDdHSB6PNN3uUGGJa+EOcm+OgeWVSYKozcRsJo2f iswo1Kc6vjiZhjG4IuCplkEiydDv8cRl5ixg2j/ap0gzGu5kVLo3mktqCDVN17jos8 vt2BPlJ+d678Q== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id B4A5660B34; Fri, 16 Aug 2024 09:56:37 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id EB4441BF292 for ; Fri, 16 Aug 2024 09:56:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id D756740141 for ; Fri, 16 Aug 2024 09:56:35 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id vjx9eIdjOP_K for ; Fri, 16 Aug 2024 09:56:35 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=193.142.43.55; helo=galois.linutronix.de; envelope-from=kurt@linutronix.de; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 42B114010D DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 42B114010D Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by smtp2.osuosl.org (Postfix) with ESMTPS id 42B114010D for ; Fri, 16 Aug 2024 09:56:34 +0000 (UTC) From: Kurt Kanzenbach To: Sebastian Andrzej Siewior In-Reply-To: <20240816093838.ZpGD38t-@linutronix.de> References: <20240711-b4-igb_zero_copy-v6-0-4bfb68773b18@linutronix.de> <20240711-b4-igb_zero_copy-v6-1-4bfb68773b18@linutronix.de> <20240816093838.ZpGD38t-@linutronix.de> Date: Fri, 16 Aug 2024 11:56:30 +0200 Message-ID: <87wmkgu6y9.fsf@kurt.kurt.home> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1723802192; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jESmOZLP8UWnsshEocvlvp6ISx76GNAGMqVLR6BonUk=; b=zxoZ0ClwFcz2e0qMb2F+ALD90vEBdUixozBxCrn+8jl1o66ulK6HCR/Jx68mLUUW8JKxiX JW7WPfXzNeK33EQ2OZM4eyjMOSGT/GaTSYN0QBpNpw1tzPoKhK1Ez6MwFSF/ULk9FGj2sM 2a0m0seUPBc7vxAIaioWaw0haFt7nXE5tWbh9m5FR1h1ACLYM4H2VEl91f4yyQ5ACcUjQ0 Mr2k1izecsPLHuj/HGAMY9zmcUP0OYd+7EsDU4n6WJK1HuKYqEGJvP/v5dqrmaMcK5yqKE SI+JeSHRySSZh5RYKSQRx3gdRqGAHBh0xj2aFA7Pm3NZeZeBKJNrMcseJAqVFw== X-Mailman-Original-DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1723802192; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jESmOZLP8UWnsshEocvlvp6ISx76GNAGMqVLR6BonUk=; b=WcH/q3OK+suGA9AIiolbtMLY7MZCHuZMu0xnvBs7Cvzqk9bRQBQ/BRxhripc7H1sDbba5O Wu6uPH1qesXZ4bAw== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=none dis=none) header.from=linutronix.de X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=linutronix.de header.i=@linutronix.de header.a=rsa-sha256 header.s=2020 header.b=zxoZ0Clw; dkim=pass header.d=linutronix.de header.i=@linutronix.de header.a=ed25519-sha256 header.s=2020e header.b=WcH/q3OK Subject: Re: [Intel-wired-lan] [PATCH iwl-next v6 1/6] igb: Always call igb_xdp_ring_update_tail() under Tx lock X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maciej Fijalkowski , Jesper Dangaard Brouer , Daniel Borkmann , Sriram Yagnaraman , Przemek Kitszel , Richard Cochran , John Fastabend , Alexei Starovoitov , Sriram Yagnaraman , Benjamin Steinke , Eric Dumazet , netdev@vger.kernel.org, Tony Nguyen , intel-wired-lan@lists.osuosl.org, Jakub Kicinski , bpf@vger.kernel.org, Paolo Abeni , "David S. Miller" Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Fri Aug 16 2024, Sebastian Andrzej Siewior wrote: > On 2024-08-16 11:24:00 [+0200], Kurt Kanzenbach wrote: >> index 11be39f435f3..4d5e5691c9bd 100644 >> --- a/drivers/net/ethernet/intel/igb/igb_main.c >> +++ b/drivers/net/ethernet/intel/igb/igb_main.c >> @@ -2914,6 +2914,7 @@ static int igb_xdp(struct net_device *dev, struct = netdev_bpf *xdp) >> } >> } >>=20=20 >> +/* This function assumes __netif_tx_lock is held by the caller. */ >> static void igb_xdp_ring_update_tail(struct igb_ring *ring) >> { >> /* Force memory writes to complete before letting h/w know there > This > lockdep_assert_held(txring_txq(ring)->_xmit_lock); > would be more powerful than the comment ;) Probably yes :-). Thanks, Kurt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJHBAEBCgAxFiEEvLm/ssjDfdPf21mSwZPR8qpGc4IFAma/Ik4THGt1cnRAbGlu dXRyb25peC5kZQAKCRDBk9HyqkZzgvy7EACdXa4mHcircC6NlXZt/nWX6xwMHDiA 9osVQPXuXOXab6fhrCOwI2QmaTcUHxKwK3yQZo+4CMopI4ne34357YpRYySXezrM 65+LmiCkX6AJm72mT3PByWURiF7c8cdRl8u/WQF0+qXjUb2tEZutrOYKP2QlDzLN 8N1NZPz8BDWSBnWR9PPRcO6oufuchIx6d1FKUshyH6EbQ/Xha9ixzt+UktTxpS1w ruwgUECR1zMulpTSwwdLVss2d8FsJwBoG0z3wMTtNYffyZ8eXJ+N7rjte8IpFckP ntjZSMR4iGT9rwvREegdPdMzovPYIIPIdvmPv+9iXwWTkgLRi9wsd8yHmYzR/0re XooZSoTqYZFAKJ38myZmmnr0V1GNbCHjISWgUGLSA6ZBDvYnr7Ci9XwK03a5XoWy BB8AXpRw8GDhqVws7lPV0Y/T9DcjL2ODUvF00sLaWTdrU1srjBf72r94VhpW8+CF vXP/M7luxP/LY0sfM66Cw+iN/HEsCbiKsaRsHohFddSY2cKZxuvTYPyFQZdJmlfe K1r7LeLAbV6WcIFC1ia33k8E6Va1n01w+KYCmWUKOfpOdE4JbUiBWIelNqWiDLfW sAKNscYy+D+m/5/A/rAdE4gcw/1704tRHf9rXnUbLvxK64QY4j6U2+mRZ4XbD7zm DvFijdRBa8Nl8A== =w0GY -----END PGP SIGNATURE----- --=-=-=--