From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH] ice: use min() to make code cleaner in ice_gnss
Date: Fri, 18 Mar 2022 13:19:26 -0700 [thread overview]
Message-ID: <8822dfa2-bdb8-fceb-e920-94afb50881e8@intel.com> (raw)
In-Reply-To: <20220318094629.526321-1-wanjiabing@vivo.com>
On 3/18/2022 2:46 AM, Wan Jiabing wrote:
> Fix the following coccicheck warning:
> ./drivers/net/ethernet/intel/ice/ice_gnss.c:79:26-27: WARNING opportunity for min()
>
> Use min() to make code cleaner.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
There are build issues with this patch:
In file included from ./include/linux/kernel.h:26,
???????????????? from drivers/net/ethernet/intel/ice/ice.h:9,
???????????????? from drivers/net/ethernet/intel/ice/ice_gnss.c:4:
drivers/net/ethernet/intel/ice/ice_gnss.c: In function ?ice_gnss_read?:
./include/linux/minmax.h:20:35: error: comparison of distinct pointer
types lacks a cast [-Werror]
?? 20 |???????? (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
????? |?????????????????????????????????? ^~
./include/linux/minmax.h:26:18: note: in expansion of macro ?__typecheck?
?? 26 |???????????????? (__typecheck(x, y) && __no_side_effects(x, y))
????? |????????????????? ^~~~~~~~~~~
./include/linux/minmax.h:36:31: note: in expansion of macro ?__safe_cmp?
?? 36 |???????? __builtin_choose_expr(__safe_cmp(x, y), \
????? |?????????????????????????????? ^~~~~~~~~~
./include/linux/minmax.h:45:25: note: in expansion of macro ?__careful_cmp?
?? 45 | #define min(x, y)?????? __careful_cmp(x, y, <)
????? |???????????????????????? ^~~~~~~~~~~~~
drivers/net/ethernet/intel/ice/ice_gnss.c:79:30: note: in expansion of
macro ?min?
?? 79 |???????????????? bytes_read = min(bytes_left,
ICE_MAX_I2C_DATA_SIZE);
????? |????????????????????????????? ^~~
cc1: all warnings being treated as errors
next prev parent reply other threads:[~2022-03-18 20:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 9:46 [Intel-wired-lan] [PATCH] ice: use min() to make code cleaner in ice_gnss Wan Jiabing
2022-03-18 20:19 ` Tony Nguyen [this message]
2022-03-19 4:24 ` Wan Jiabing
2022-03-21 11:54 ` Alexander Lobakin
2022-03-21 12:02 ` Jiabing Wan
2022-03-21 15:47 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8822dfa2-bdb8-fceb-e920-94afb50881e8@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox