From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Michal Michalik <michal.michalik@intel.com>,
<intel-wired-lan@lists.osuosl.org>
Cc: karol.kolacinski@intel.com, jesse.brandeburg@intel.com
Subject: Re: [Intel-wired-lan] [PATCH net-next v2 2/3] ice: Use PTP auxbus for all PHYs restart in E822
Date: Tue, 25 Jul 2023 10:52:09 -0700 [thread overview]
Message-ID: <89f4ec10-2e4f-49ef-f7cd-0a74ccd1f854@intel.com> (raw)
In-Reply-To: <20230721154424.11834-3-michal.michalik@intel.com>
On 7/21/2023 8:44 AM, Michal Michalik wrote:
...
> @@ -1927,9 +1945,9 @@ ice_ptp_settime64(struct ptp_clock_info *info, const struct timespec64 *ts)
> /* Reenable periodic outputs */
> ice_ptp_enable_all_clkout(pf);
>
> - /* Recalibrate and re-enable timestamp block */
> - if (pf->ptp.port.link_up)
> - ice_ptp_port_phy_restart(&pf->ptp.port);
> + /* Recalibrate and re-enable timestamp blocks for E822/E823 */
> + if (!ice_is_e810(hw))
Should this use PHY model since this is coming after it [1]?
> + ice_ptp_restart_all_phy(pf);
> exit:
> if (err) {
> dev_err(ice_pf_to_dev(pf), "PTP failed to set time %d\n", err);
[1]
https://lore.kernel.org/intel-wired-lan/20230717221713.2249044-1-jacob.e.keller@intel.com/
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-07-25 17:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 15:44 [Intel-wired-lan] [PATCH net-next v2 0/3] ice: add PTP auxiliary bus support Michal Michalik
2023-07-21 15:44 ` [Intel-wired-lan] [PATCH net-next v2 1/3] ice: Auxbus devices & driver for E822 TS Michal Michalik
2023-07-25 17:51 ` Tony Nguyen
2023-07-27 13:04 ` Michalik, Michal
2023-07-21 15:44 ` [Intel-wired-lan] [PATCH net-next v2 2/3] ice: Use PTP auxbus for all PHYs restart in E822 Michal Michalik
2023-07-25 17:52 ` Tony Nguyen [this message]
2023-07-27 12:35 ` Michalik, Michal
2023-07-21 15:44 ` [Intel-wired-lan] [PATCH net-next v2 3/3] ice: PTP: add clock domain number to auxiliary interface Michal Michalik
2023-07-25 17:52 ` Tony Nguyen
2023-07-25 17:54 ` Jacob Keller
2023-07-27 12:05 ` Michalik, Michal
2023-07-25 18:00 ` [Intel-wired-lan] [PATCH net-next v2 0/3] ice: add PTP auxiliary bus support Tony Nguyen
2023-07-27 13:07 ` Michalik, Michal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89f4ec10-2e4f-49ef-f7cd-0a74ccd1f854@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=karol.kolacinski@intel.com \
--cc=michal.michalik@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox