Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>,
	<intel-wired-lan@osuosl.org>
Cc: pmenzel@molgen.mpg.de, mallikarjuna.chilakala@intel.com
Subject: Re: [Intel-wired-lan] [PATCH v2] igc: Enhance Qbv scheduling by using first flag bit
Date: Wed, 2 Nov 2022 14:40:30 -0700	[thread overview]
Message-ID: <8a1dfa75-d164-e9a4-36c4-4f57b68fc055@intel.com> (raw)
In-Reply-To: <20221025140307.2330-1-muhammad.husaini.zulkifli@intel.com>



On 10/25/2022 7:03 AM, Muhammad Husaini Zulkifli wrote:

One more that I missed...

> +static inline bool igc_ipv6_csum_is_sctp(struct sk_buff *skb)
> +{

No 'inline' in c files.

> +	unsigned int offset = 0;
> 
> -		skb_txtime_consumed(first->skb);
> -		context_desc->launch_time = igc_tx_launchtime(adapter,
> -							      txtime);
> -	} else {
> -		context_desc->launch_time = 0;
> -	}
> +	ipv6_find_hdr(skb, &offset, IPPROTO_SCTP, NULL, NULL);
> +
> +	return offset == skb_checksum_start_offset(skb);
>   }
> 

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

  parent reply	other threads:[~2022-11-02 21:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-25 14:03 [Intel-wired-lan] [PATCH v2] igc: Enhance Qbv scheduling by using first flag bit Muhammad Husaini Zulkifli
2022-11-02 21:33 ` Tony Nguyen
2022-11-03  1:13   ` Zulkifli, Muhammad Husaini
2022-11-03 18:15     ` Tony Nguyen
2022-11-02 21:40 ` Tony Nguyen [this message]
2022-11-03  2:52   ` Zulkifli, Muhammad Husaini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8a1dfa75-d164-e9a4-36c4-4f57b68fc055@intel.com \
    --to=anthony.l.nguyen@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    --cc=mallikarjuna.chilakala@intel.com \
    --cc=muhammad.husaini.zulkifli@intel.com \
    --cc=pmenzel@molgen.mpg.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox