Re: [Intel-wired-lan] [PATCH net-next 2/3] igc: Remove unused igc_read/write_pci_cfg wrappers

["Lifshits, Vitaly" <vitaly.lifshits@intel.com>]

On 1/2/2025 7:41 PM, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> igc_read_pci_cfg() and igc_write_pci_cfg were added in 2018 as part of
> commit 146740f9abc4 ("igc: Add support for PF")
> but have remained unused.
> 
> Remove them.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Reviewed-by: Vitaly Lifshits <vitaly.lifshits@intel.com>

> ---
>   drivers/net/ethernet/intel/igc/igc_hw.h   |  2 --
>   drivers/net/ethernet/intel/igc/igc_main.c | 14 --------------
>   2 files changed, 16 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/igc/igc_hw.h b/drivers/net/ethernet/intel/igc/igc_hw.h
> index d9d1a1a11daf..7ec7e395020b 100644
> --- a/drivers/net/ethernet/intel/igc/igc_hw.h
> +++ b/drivers/net/ethernet/intel/igc/igc_hw.h
> @@ -281,7 +281,5 @@ struct net_device *igc_get_hw_dev(struct igc_hw *hw);
>   
>   s32  igc_read_pcie_cap_reg(struct igc_hw *hw, u32 reg, u16 *value);
>   s32  igc_write_pcie_cap_reg(struct igc_hw *hw, u32 reg, u16 *value);
> -void igc_read_pci_cfg(struct igc_hw *hw, u32 reg, u16 *value);
> -void igc_write_pci_cfg(struct igc_hw *hw, u32 reg, u16 *value);
>   
>   #endif /* _IGC_HW_H_ */
> diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
> index 27872bdea9bd..9c92673a7240 100644
> --- a/drivers/net/ethernet/intel/igc/igc_main.c
> +++ b/drivers/net/ethernet/intel/igc/igc_main.c
> @@ -6780,20 +6780,6 @@ static const struct net_device_ops igc_netdev_ops = {
>   };
>   
>   /* PCIe configuration access */
> -void igc_read_pci_cfg(struct igc_hw *hw, u32 reg, u16 *value)
> -{
> -	struct igc_adapter *adapter = hw->back;
> -
> -	pci_read_config_word(adapter->pdev, reg, value);
> -}
> -
> -void igc_write_pci_cfg(struct igc_hw *hw, u32 reg, u16 *value)
> -{
> -	struct igc_adapter *adapter = hw->back;
> -
> -	pci_write_config_word(adapter->pdev, reg, *value);
> -}
> -
>   s32 igc_read_pcie_cap_reg(struct igc_hw *hw, u32 reg, u16 *value)
>   {
>   	struct igc_adapter *adapter = hw->back;
>