From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Benjamin Mikailenko <benjamin.mikailenko@intel.com>,
<intel-wired-lan@lists.osuosl.org>
Subject: Re: [Intel-wired-lan] [net-next, v7 2/2] ice: Accumulate ring statistics over reset
Date: Fri, 18 Nov 2022 13:22:16 -0800 [thread overview]
Message-ID: <8bfc72e6-4dbb-0aff-b135-d2945ffb5098@intel.com> (raw)
In-Reply-To: <20221118192042.14329-3-benjamin.mikailenko@intel.com>
On 11/18/2022 11:20 AM, Benjamin Mikailenko wrote:
...
> diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c
> index fea65735b2ad..5762a5035ef4 100644
> --- a/drivers/net/ethernet/intel/ice/ice_lib.c
> +++ b/drivers/net/ethernet/intel/ice/ice_lib.c
> @@ -447,6 +447,52 @@ static irqreturn_t ice_eswitch_msix_clean_rings(int __always_unused irq, void *d
> return IRQ_HANDLED;
> }
>
> +/**
> + * ice_vsi_alloc_stat_arrays - Allocate statistics arrays
> + * @vsi: VSI pointer
> + */
> +static int ice_vsi_alloc_stat_arrays(struct ice_vsi *vsi)
> +{
> + struct ice_vsi_stats *vsi_stat;
> + struct ice_pf *pf = vsi->back;
> + struct device *dev;
> +
> + dev = ice_pf_to_dev(pf);
This is no longer used:
> ../drivers/net/ethernet/intel/ice/ice_lib.c: In function
‘ice_vsi_alloc_stat_arrays’:
> ../drivers/net/ethernet/intel/ice/ice_lib.c:458:17: warning: variable
‘dev’ set but not used [-Wunused-but-set-variable]
> struct device *dev;
...
> +/**
> + * ice_vsi_free_stats - Free the ring statistics structures
> + * @vsi: VSI pointer
> + */
> +static void ice_vsi_free_stats(struct ice_vsi *vsi)
> +{
> + struct ice_vsi_stats *vsi_stat;
> + struct ice_pf *pf = vsi->back;
> + struct device *dev;
> + int i;
> +
> + dev = ice_pf_to_dev(pf);
Same here:
> ../drivers/net/ethernet/intel/ice/ice_lib.c: In function
‘ice_vsi_free_stats’:
> ../drivers/net/ethernet/intel/ice/ice_lib.c:1597:17: warning:
variable ‘dev’ set but not used [-Wunused-but-set-variable]
> struct device *dev;
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
prev parent reply other threads:[~2022-11-18 21:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 19:20 [Intel-wired-lan] [net-next, v7 0/2] Accumulate statistics over reset Benjamin Mikailenko
2022-11-18 19:20 ` [Intel-wired-lan] [net-next, v7 1/2] ice: Accumulate HW and Netdev " Benjamin Mikailenko
2022-11-18 19:20 ` [Intel-wired-lan] [net-next, v7 2/2] ice: Accumulate ring " Benjamin Mikailenko
2022-11-18 21:22 ` Tony Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bfc72e6-4dbb-0aff-b135-d2945ffb5098@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=benjamin.mikailenko@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox