From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AEB1AC4828F for ; Thu, 8 Feb 2024 12:03:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 403516FA18; Thu, 8 Feb 2024 12:03:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 87H10aRGxAHe; Thu, 8 Feb 2024 12:03:44 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 746AA6F7A0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1707393824; bh=MV1yo5pvfobG9sKsA9OcsmY4U7pun3JqqpqPRAnk9YY=; h=Date:To:References:From:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=L/gF2jTbQW2vd2E6uu+b9YrLasXouWYwwZqgThImmLxHatYFZ0NYSuB4jZjFgyrgb rokDgBIBTxoCl428VOVcL5H49hHmuiJkXg0ITw3Uh4Or1EfbWFQjX1hdSlYmO/Pzmz ZJsQFtZ3Chwk4kmYCOi9KBQHRjzoGDwurTK3I1em8DnyCwiUeyRMcoTdVP9XiD/nxu scckD4Nb7R9lwHj/XVltK2PLXLkFVPV/JWHW0n1wRUMmQ/IfDuAjbUmtPC8AIYTait Cqdf5s8Vcm6/irQh9Jp3GwjlXpBSXqAQ6OiDR4+0t1ejkpBTG+oOks23AFUWom+Pf0 7P9s+NFbTI2Yw== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 746AA6F7A0; Thu, 8 Feb 2024 12:03:44 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 806C31BF37C for ; Thu, 8 Feb 2024 12:03:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 7990942FC4 for ; Thu, 8 Feb 2024 12:03:42 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ySHNCG4t6KBw for ; Thu, 8 Feb 2024 12:03:41 +0000 (UTC) X-Greylist: delayed 428 seconds by postgrey-1.37 at util1.osuosl.org; Thu, 08 Feb 2024 12:03:41 UTC DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 7BEAF42FC3 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 7BEAF42FC3 Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.17; helo=mgamail.intel.com; envelope-from=lukasz.plachno@intel.com; receiver= Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by smtp4.osuosl.org (Postfix) with ESMTPS id 7BEAF42FC3 for ; Thu, 8 Feb 2024 12:03:41 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6600,9927,10977"; a="1088987" X-IronPort-AV: E=Sophos;i="6.05,253,1701158400"; d="scan'208";a="1088987" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2024 03:56:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,253,1701158400"; d="scan'208";a="6265103" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmviesa004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 08 Feb 2024 03:56:32 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 8 Feb 2024 03:56:31 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 8 Feb 2024 03:56:31 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 8 Feb 2024 03:56:31 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zi1BVSvK5vKUJlnHAZ8fR4zK7LGVd6Ysul2emeB3Asno3KKqpRMA5JlSP+InQosUngzZPweVdrrN+cSFcKqwr+m2U7vGw9/LvEd0S0lr2qtVBCDyiULauzZNc68Z7fcu/1/vYZKuVbXieM8vBgKfZW/R0KUsuQZ1X5Sfhv/OJZZiq19mLD0wJgnG6zZyj7Cyq8FKFFCE57CRSOoRtfaW7ViLs3VZSiGiXgckszpgptIPzFtHeeCEaNfB3O6SXryNMq6115JcJ9BZovK2b+dkKO7uZnkO5Tb04d5f/gAGJ16kKEY3yhbnOlBTVo3W2i4ofN1+t3jqF73zYCIyTATVjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MV1yo5pvfobG9sKsA9OcsmY4U7pun3JqqpqPRAnk9YY=; b=YLvRo8vNiA0rD0YkZsyka/uRImGIyMorov+PVDa5+WYKufggiB6GZoxtVH1kuNmdvbcA6eOE/G4UvYioF9AejE5cgkncTofZd+lYiiqayxIywhVj4QqfLM/8zm2nbHWiu5iIXO213lmPM5lyAS9RweJ628iojQGSnnS7LkHHJVHr/T14bVoMTwu+MnoPXFa9OTvytQuvWnbXoBv0iuTCzyHNxZh0SWGk1l/BzZJhbYHDQRJggkPj+ws1Azr8kGbeSS2tLeTXLaQv5XyCJ2S7L+NME3n81ge6UDRq2biVPeNyKGj8pLuhcybaUzewbCBZNUBITuSG4ra2b4r+DYRlmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from LV8PR11MB8464.namprd11.prod.outlook.com (2603:10b6:408:1e7::17) by PH7PR11MB5983.namprd11.prod.outlook.com (2603:10b6:510:1e2::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.36; Thu, 8 Feb 2024 11:56:29 +0000 Received: from LV8PR11MB8464.namprd11.prod.outlook.com ([fe80::9e80:a6c6:5f1:d19b]) by LV8PR11MB8464.namprd11.prod.outlook.com ([fe80::9e80:a6c6:5f1:d19b%4]) with mapi id 15.20.7270.024; Thu, 8 Feb 2024 11:56:29 +0000 Message-ID: <8e4148bf-71b1-48dd-a2a4-84a46f2cd66e@intel.com> Date: Thu, 8 Feb 2024 12:56:23 +0100 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Alexander Lobakin References: <20240206163337.11415-1-lukasz.plachno@intel.com> <20240206163337.11415-3-lukasz.plachno@intel.com> <9deb3115-eb04-4b18-90de-c884b91dc101@intel.com> From: "Plachno, Lukasz" In-Reply-To: <9deb3115-eb04-4b18-90de-c884b91dc101@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: WA0P291CA0008.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:1::24) To LV8PR11MB8464.namprd11.prod.outlook.com (2603:10b6:408:1e7::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PR11MB8464:EE_|PH7PR11MB5983:EE_ X-MS-Office365-Filtering-Correlation-Id: fb43e724-004f-4adb-0edf-08dc289cfc10 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ayd452ow3gqLOa22Lxo5V3gRSh2DwpLR98UOlNeKo96PdhM2WMhsEjGGOSRcgUA+J0uO77EPuBbornNgeiw2PK7WhP8l8WQRi0z0oFBxK3olgiPOM5bDwA0NBB42zrEV62h2p75OPl7zXYIKBiMkFSdBLH5C/Xjwj8f1DqWKwh029h+bMI2GqoBK9L4gTxDxC0aFqZ2FaFlUcyPyL/I4Vnk6CFhEMYk2VBObN4f14ey+PqJ2VyJE5Svzi+aK9H4Rrf4yaofko2eJrvsWYImB9qvTlQsMoRphI5u5u4Ss6GjJQ/70zmg/DOYJ7vDEJYXSfEMl05D3//WWDIlgoooZ8AkzQpZpiFs6IAfAnjo0a4N5ivMB8xUsLiPyvjppP7veN5oiNyqmbTZKCeH1Arvf1OQsjhXdVZugl8MREyQvfRjZzOyKmVZ9NbDhtD/ZlrrL4hpEsx9rUXFYoyIrvhAaRtQTT+Tp4StM1qLO6K6scTCqrLBg2JcB31IJb+4L1AIr0e+EeJO224NttxnwuKh7mH+fSwo2jIJ3qmyBEGUz30xaNKIG+4s9Ic6GLWC48FFP X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:LV8PR11MB8464.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(39860400002)(136003)(366004)(396003)(346002)(230922051799003)(451199024)(186009)(1800799012)(64100799003)(41300700001)(2616005)(31696002)(4326008)(8676002)(86362001)(6862004)(53546011)(107886003)(36756003)(6486002)(6506007)(478600001)(6666004)(5660300002)(6512007)(8936002)(6636002)(66946007)(54906003)(66556008)(37006003)(66476007)(316002)(26005)(83380400001)(2906002)(38100700002)(31686004)(82960400001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TWFiK2duVzQrTlBjSmMvWXhqWmE1VldBWnlnckdRbFFXRjF4RXdkU1V6TS94?= =?utf-8?B?SzlVOGlmRjlkeGdKYmFaMlhSd3NvMVBsRDJsWkloMmlZYWsza0NObW1LMW05?= =?utf-8?B?c2plREd0TGZYVnlxYU1pN3dsTER5N1NSanYrd1lFa3l4aFN3NkFPYTRIVUw0?= =?utf-8?B?c2JyQ2hVV0wrSEZxNGhRVG9nWXVKbnc2NlFPZEFXaERKZzlNQjNOckNqYTNo?= =?utf-8?B?Wm5Rak4vc3dhcHR5S3B6d3dUTEd0QStlaGRPTEQ2UnpTaFQ1VS8zTyt3VG9Y?= =?utf-8?B?NTFLS0ZlSXR4eEU3aTJXODhNektPcHNmODYwMjVyL0M5WExsa0VTTWVEL1NE?= =?utf-8?B?WDd0L21wdHJxNVJhSkViaFFSZ1FlcTFyam9BbXZsQzhXSlhibU91alJHSXV3?= =?utf-8?B?czVHdjU3cXFUdTROOUI0SkloWFNtV2xpeVczVlJ3WWY3QzJEUmg3Rmc1Smsw?= =?utf-8?B?WDJPZnhrQm9wZGY1UHg2cGNNZURPaXlWUlJKNzUyUllXVDZVM1R1Q3BlM1Zu?= =?utf-8?B?MThGOFlYYk4zTnBqd3dvTWRKWlQ2Njd6UUNIVXA4UzM2UWNRMi84S2hGeGNQ?= =?utf-8?B?bnJzSGZCYXpwc2hmQ282ekpnckI3UXJ3OExhb2tZREtLZmtWYVpZamZ6UWNJ?= =?utf-8?B?c0kvMGdzcFFDdHowUHhnOFVkRCtDVDJiNUh3a0hYbW5pNUNwSTcyU1lNekh0?= =?utf-8?B?Yk0rblJrL3pmNHNqWG1xVzFsTzNrNFB2aDlzeWJnQngzR3pUY043bHhEWDQz?= =?utf-8?B?NFY5bHArdUx6MzBvTTJzY2xrL0V4QWV2bDJJTnF4b0tEblo3ZnpzQkFFdm1t?= =?utf-8?B?VzRTYUpxSlJEY0RibmZpczhna2NjWEVlM3VkTTQyb2NWY3MwSE5FQS9KbklM?= =?utf-8?B?V0JVT1FYZjNBVHpNSk1NOWpkMWdVVlYwWGZ0NzRZNUx2ZEI4STVMWTlub1Jk?= =?utf-8?B?N3hDa1owbUgvRXcrRHJtK21YYmpJenVBdE92cXlOdXJZVmU2VUlwSHhlVHk4?= =?utf-8?B?TDBBMDdjTlNYc3lIVWJGYlU1RjI3eXArRFJoZitMY3BqQ0Q3dDNXQ2Jacm9o?= =?utf-8?B?UnYyeVZ0Y3dNc1F4SmtNLytRNUJ5UzlYR3ZsZWhkdGNieXJRSFNzUFNTU1lC?= =?utf-8?B?eEFLdUFQQlA2U0Y3eFZrbGVjMllvQWVpdVFTemdVU2JLVDJRd2NEcTVXdnEr?= =?utf-8?B?K3p0bXh5cXNWd0hmTmM4cjJQZTgrYnpNK0RSUDB2UW5wWWNNOG9wbXRSbzlR?= =?utf-8?B?aTBkUGw3akxEcmhhaldFMXRYbGpQZ1FKOFhhdEJERW43RTNDVDBxUjZWMkhV?= =?utf-8?B?b3dsREVCbGhHQzRoaXhuTUJEenAzMyt6Y0xrOFJvTDRjeWJvTnlQUkVqdWFl?= =?utf-8?B?ak5VZ2RlZS92NlRzdmtrazRqM09Fcm42U3VnN2pxWFdOUVFQL1UzVFpWb1FQ?= =?utf-8?B?VjNuV3VDUjZvQjVzRGJHNWRZdTJHUzREc0dlMUlPQ3ZnT08zRW0wQ2NyTm8r?= =?utf-8?B?dDlOcE9oU25YMXhJaHBWMWJJRU1lL21MelA4Z3BpR0lTY1Z0YkxjRjBDc2Uv?= =?utf-8?B?N1ZhTVdmejJEdWZMTnJoRlpIOE41TU9oOFBlZTFvY1lMVzFGY21aL2NhM2JK?= =?utf-8?B?cmNhQW5CYUZmYkFkZ3JscXczM3l0ZjJ4MzBzUGZ1RFRlUXU4bDFPL2Vzb2Zl?= =?utf-8?B?cVNGR0x5eEtGOEx4UldDU0dxWGxHRjBHcVNISmhCUER1T2ZmVHhtRy9lU3kv?= =?utf-8?B?dVlRWFJNWC9FL2NVSE1uVXhDaTlvREF4U1FYenVSbmhVUDlZdXJSQTROYkhz?= =?utf-8?B?U3l2U1JtNGN2VUlBd1BzUFh4VTZXQjZEbzFCWW5JYlJWUnVndHltdVZPNHVO?= =?utf-8?B?YlpQOWMrVEJQcFl3OGZxYUhxZjZlTXFmL2k1U3VMZTBtQ2ZFUXhUeG5rR2pX?= =?utf-8?B?RFVuUWpIWlpOQ2xZWHJXd2MzWmhoemxVTUNVU0MyR2lzeUU4azhYL1IrY3Zl?= =?utf-8?B?RjZPL2wxampyd0NTMUdUME5zUCtPQlVCNkpqdW1MWW1ocENHdFZidURMZHdP?= =?utf-8?B?TmpTYksxeEdabURXaU1Tdmd6b1JhQllqTTlVRkpLSTFjRjRmYllGMnhuYWlG?= =?utf-8?B?M1EvbTVBUUZYYmtxRGZUdDBZZVpWelhlQWZ4K1dsakFtUTgzblY1S0ZPZmhn?= =?utf-8?B?ZGc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: fb43e724-004f-4adb-0edf-08dc289cfc10 X-MS-Exchange-CrossTenant-AuthSource: LV8PR11MB8464.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2024 11:56:29.0722 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wkZyDjPKbXzgiEvsQMiiNGG7/pagB8XiOLLJZ8t8VCdMkNo5YB7Ichy28d0t5qfoF08LTWhv6uh8V6C/FriqlhpmuvnKLOKfifRXBwGLkWs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5983 X-OriginatorOrg: intel.com X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707393821; x=1738929821; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=4BXMDWqT5sLKCHGl2Q6MGHUabUUSf7l7cWK9EN6oZ5c=; b=di1bzsaCZrQgBqJ3EXPCbAgTx+Mh5zIBVd9vDH1BNJK+zdNv9x8JKPdX CSR6TooLhJxnPHPK6etl88vZZpJssKKQi7+1f0OyTXMPVyZP++y5MKmxQ XyShot8RSFSkPOoIJwSNqVhgO710bgjn5XHGqri70Hgqax3zCeCu+ES7I 9c+8hIqbigrkCZyIK9dHUuzb6QHYtAiiU6MiRcymnMGfm8idz1N4klJzf 9bCDC3bqzT+zU6iT6AkCOwTgZzFNFBzQrqHh8ML/VdcGWbfGFBCs/JBdd 5fLst5IaoMboEYuL3cjCnRvChLe4BdSLkgfU2FWZPlOQ+lF+9mzWohRDu w==; X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=none dis=none) header.from=intel.com X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=di1bzsaC X-Mailman-Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Subject: Re: [Intel-wired-lan] [PATCH iwl-next v5 2/2] ice: Implement 'flow-type ether' rules X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pmenzel@molgen.mpg.de, brett.creeley@amd.com, netdev@vger.kernel.org, Jakub Buchocki , intel-wired-lan@lists.osuosl.org, horms@kernel.org, Mateusz Pacuszka , Przemek Kitszel Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On 2/7/2024 3:07 PM, Alexander Lobakin wrote: > From: Lukasz Plachno > Date: Tue, 6 Feb 2024 17:33:37 +0100 > >> From: Jakub Buchocki >> >> Add support for 'flow-type ether' Flow Director rules via ethtool. >> >> Create packet segment info for filter configuration based on ethtool >> command parameters. Reuse infrastructure already created for >> ipv4 and ipv6 flows to convert packet segment into >> extraction sequence, which is later used to program the filter >> inside Flow Director block of the Rx pipeline. > > [...] > >> diff --git a/drivers/net/ethernet/intel/ice/ice_fdir.c b/drivers/net/ethernet/intel/ice/ice_fdir.c >> index 1f7b26f38818..5fe0bad00fd7 100644 >> --- a/drivers/net/ethernet/intel/ice/ice_fdir.c >> +++ b/drivers/net/ethernet/intel/ice/ice_fdir.c >> @@ -4,6 +4,8 @@ >> #include "ice_common.h" >> >> /* These are training packet headers used to program flow director filters. */ >> +static const u8 ice_fdir_eth_pkt[22] = {0}; > > I believe this zeroing is not needed, just declare it and the compiler > will zero it automatically. > {0}; will be removed in V6 > [...] > >> @@ -97,6 +100,12 @@ struct ice_rx_flow_userdef { >> u16 flex_fltr; >> }; >> >> +struct ice_fdir_eth { >> + u8 dst[ETH_ALEN]; >> + u8 src[ETH_ALEN]; >> + __be16 type; >> +}; > > This is clearly `struct ethhdr`, please remove this duplicating > definition and just use the generic structure. > I will fix that in V6, thank you for catching that. Regards, Łukasz