From: Marcin Szycik <marcin.szycik@linux.intel.com>
To: Tony Nguyen <anthony.l.nguyen@intel.com>,
intel-wired-lan@lists.osuosl.org
Subject: Re: [Intel-wired-lan] [PATCH net-next v2] ice: Add support for ip TTL & ToS offload
Date: Fri, 29 Jul 2022 10:40:34 +0200 [thread overview]
Message-ID: <8e65876e-4168-e5bb-813c-3bba478a11fb@linux.intel.com> (raw)
In-Reply-To: <f8e9e966-8d98-9a17-298f-d2e791e5359d@intel.com>
On 28-Jul-22 18:14, Tony Nguyen wrote:
> On 7/6/2022 9:26 AM, Marcin Szycik wrote:
>> Add support for parsing TTL and ToS (Hop Limit and Traffic Class) tc fields
>> and matching on those fields in filters. Incomplete part of implementation
>> was already in place (getting enc_ip and enc_tos from flow_match_ip and
>> writing them to filter header).
>>
>> Note: matching on ipv6 ip_ttl, enc_ttl and enc_tos is currently not
>> supported by the DDP package.
>>
>> Signed-off-by: Marcin Szycik <marcin.szycik@linux.intel.com>
>> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
>> ---
>
> <snip>
>
>> diff --git a/drivers/net/ethernet/intel/ice/ice_tc_lib.h b/drivers/net/ethernet/intel/ice/ice_tc_lib.h
>> index 0193874cd203..7da9b92e3b49 100644
>> --- a/drivers/net/ethernet/intel/ice/ice_tc_lib.h
>> +++ b/drivers/net/ethernet/intel/ice/ice_tc_lib.h
>> @@ -24,9 +24,15 @@
>> #define ICE_TC_FLWR_FIELD_ETH_TYPE_ID BIT(17)
>> #define ICE_TC_FLWR_FIELD_ENC_OPTS BIT(18)
>> #define ICE_TC_FLWR_FIELD_CVLAN BIT(19)
>> +#define ICE_TC_FLWR_FIELD_IP_TOS BIT(20)
>> +#define ICE_TC_FLWR_FIELD_IP_TTL BIT(21)
>> +#define ICE_TC_FLWR_FIELD_ENC_IP_TOS BIT(22)
>> +#define ICE_TC_FLWR_FIELD_ENC_IP_TTL BIT(23)
>
> Looks like the PPPoE values [1] are now conflicting with these. As PPPoE was accepted into net-next, please update these values.
Thanks for pointing this out, I'll fix it.
>
>> #define ICE_TC_FLOWER_MASK_32 0xFFFFFFFF
>> +#define ICE_IPV6_HDR_TC_MASK 0xFF00000
>> +
>> struct ice_indr_block_priv {
>> struct net_device *netdev;
>> struct ice_netdev_priv *np;
>
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/diff/drivers/net/ethernet/intel/ice/ice_tc_lib.h?id=cd8efeeed16e8ecf30071583865f3f468db9e854
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
prev parent reply other threads:[~2022-07-29 8:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 16:26 [Intel-wired-lan] [PATCH net-next v2] ice: Add support for ip TTL & ToS offload Marcin Szycik
2022-07-28 16:14 ` Tony Nguyen
2022-07-29 8:40 ` Marcin Szycik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e65876e-4168-e5bb-813c-3bba478a11fb@linux.intel.com \
--to=marcin.szycik@linux.intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox