From: Nguyen, Anthony L <anthony.l.nguyen@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v1 1/1] igc: Remove no need includes from igc_mac.h
Date: Wed, 24 Feb 2021 00:53:57 +0000 [thread overview]
Message-ID: <8fd63311fdf508b9a7cdcd468a18cbdda6332682.camel@intel.com> (raw)
In-Reply-To: <20210223121923.1503421-1-sasha.neftin@intel.com>
On Tue, 2021-02-23 at 14:19 +0200, Sasha Neftin wrote:
> igc_defines.h and igc_phy.h included in igc_hw.h
> Therefore no need to include these headers in igc_mac.h
> where is include igc_hw.h
From the submit-checklist, we don't want to be relying on other files'
includes.
If you use a facility then #include the file that
defines/declares
that facility. Don't depend on other header files pulling in
ones
that you use.
https://www.kernel.org/doc/Documentation/process/submit-checklist.rst
Though we aren't perfect in this, we shouldn't be removing this as it's
desired.
Thanks,
Tony
prev parent reply other threads:[~2021-02-24 0:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 12:19 [Intel-wired-lan] [PATCH v1 1/1] igc: Remove no need includes from igc_mac.h Sasha Neftin
2021-02-24 0:53 ` Nguyen, Anthony L [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8fd63311fdf508b9a7cdcd468a18cbdda6332682.camel@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox