From: Mor Bar-Gabay <morx.bar.gabay@intel.com>
To: Vitaly Lifshits <vitaly.lifshits@intel.com>,
<intel-wired-lan@lists.osuosl.org>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1 1/1] igc: remove autoneg parameter from igc_mac_info
Date: Thu, 10 Oct 2024 14:16:37 +0300 [thread overview]
Message-ID: <951ec4b2-45e5-491c-ba14-d33eb1f25ae9@intel.com> (raw)
In-Reply-To: <20241001170531.1164289-1-vitaly.lifshits@intel.com>
On 01/10/2024 20:05, Vitaly Lifshits wrote:
> Since the igc driver doesn't support forced speed configuration and
> its current related hardware doesn't support it either, there is no
> use of the mac.autoneg parameter. Moreover, in one case this usage
> might result in a NULL pointer dereference due to an uninitialized
> function pointer, phy.ops.force_speed_duplex.
>
> Therefore, remove this parameter from the igc code.
>
> Signed-off-by: Vitaly Lifshits <vitaly.lifshits@intel.com>
> ---
> drivers/net/ethernet/intel/igc/igc_diag.c | 3 +-
> drivers/net/ethernet/intel/igc/igc_ethtool.c | 13 +-
> drivers/net/ethernet/intel/igc/igc_hw.h | 1 -
> drivers/net/ethernet/intel/igc/igc_mac.c | 316 +++++++++----------
> drivers/net/ethernet/intel/igc/igc_main.c | 1 -
> drivers/net/ethernet/intel/igc/igc_phy.c | 24 +-
> 6 files changed, 163 insertions(+), 195 deletions(-)
>
Tested-by: Mor Bar-Gabay <morx.bar.gabay@intel.com>
prev parent reply other threads:[~2024-10-10 11:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 17:05 [Intel-wired-lan] [PATCH iwl-next v1 1/1] igc: remove autoneg parameter from igc_mac_info Vitaly Lifshits
2024-10-10 11:16 ` Mor Bar-Gabay [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=951ec4b2-45e5-491c-ba14-d33eb1f25ae9@intel.com \
--to=morx.bar.gabay@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=vitaly.lifshits@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox