From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Jacob Keller <jacob.e.keller@intel.com>,
Intel Wired LAN <intel-wired-lan@lists.osuosl.org>
Subject: Re: [Intel-wired-lan] [net-next 3/6] ice: track Tx timestamp stats similar to other Intel drivers
Date: Wed, 27 Jul 2022 10:30:43 -0700 [thread overview]
Message-ID: <956e4d5d-c71e-fd8d-bc1d-9ed431368fde@intel.com> (raw)
In-Reply-To: <20220726234357.50610-4-jacob.e.keller@intel.com>
On 7/26/2022 4:43 PM, Jacob Keller wrote:
<snip>
> diff --git a/drivers/net/ethernet/intel/ice/ice_ptp.h b/drivers/net/ethernet/intel/ice/ice_ptp.h
> index 10e396abf130..2cabdecbb23f 100644
> --- a/drivers/net/ethernet/intel/ice/ice_ptp.h
> +++ b/drivers/net/ethernet/intel/ice/ice_ptp.h
> @@ -171,6 +171,8 @@ struct ice_ptp_port {
> * @clock: pointer to registered PTP clock device
> * @tstamp_config: hardware timestamping configuration
> * @reset_time: kernel time after clock stop on reset
> + * @tx_hwtstamp_skipped: number of Tx time stamp requests skipped
> + * @tx_hwtstamp_timeouts: number of Tx skbs discarded with no time stamp
Missed one:
drivers/net/ethernet/intel/ice/ice_ptp.h:194: warning: Function
parameter or member 'tx_hwtstamp_flushed' not described in 'ice_ptp'
> */
> struct ice_ptp {
> struct ice_ptp_port port;
> @@ -185,6 +187,9 @@ struct ice_ptp {
> struct ptp_clock *clock;
> struct hwtstamp_config tstamp_config;
> u64 reset_time;
> + u32 tx_hwtstamp_skipped;
> + u32 tx_hwtstamp_timeouts;
> + u32 tx_hwtstamp_flushed;
> };
>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2022-07-27 17:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 23:43 [Intel-wired-lan] [net-next 0/6] ice: detect and report PTP timestamp issues Jacob Keller
2022-07-26 23:43 ` [Intel-wired-lan] [net-next 1/6] ice: set tx_tstamps when creating new Tx rings via ethtool Jacob Keller
2022-07-26 23:43 ` [Intel-wired-lan] [net-next 2/6] ice: initialize cached_phctime when creating Rx rings Jacob Keller
2022-07-26 23:43 ` [Intel-wired-lan] [net-next 3/6] ice: track Tx timestamp stats similar to other Intel drivers Jacob Keller
2022-07-27 17:30 ` Tony Nguyen [this message]
2022-07-26 23:43 ` [Intel-wired-lan] [net-next 4/6] ice: track and warn when PHC update is late Jacob Keller
2022-07-27 17:33 ` Tony Nguyen
2022-07-27 17:40 ` Tony Nguyen
2022-07-26 23:43 ` [Intel-wired-lan] [net-next 5/6] ice: re-arrange some static functions in ice_ptp.c Jacob Keller
2022-07-26 23:43 ` [Intel-wired-lan] [net-next 6/6] ice: introduce ice_ptp_reset_cached_phctime function Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=956e4d5d-c71e-fd8d-bc1d-9ed431368fde@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox