From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Andrii Staikov <andrii.staikov@intel.com>,
<intel-wired-lan@lists.osuosl.org>
Cc: Karen Ostrowska <karen.ostrowska@intel.com>,
netdev@vger.kernel.org,
Drewek Wojciech <wojciech.drewek@intel.com>,
Mateusz Palczewski <mateusz.palczewski@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v3] i40e: Restore VF MSI-X state during PCI reset
Date: Thu, 7 Dec 2023 10:34:12 +0100 [thread overview]
Message-ID: <9745f1f1-b93c-3df5-e235-db2b256d610b@intel.com> (raw)
In-Reply-To: <20231206125127.218350-1-andrii.staikov@intel.com>
On 12/6/23 13:51, Andrii Staikov wrote:
> During a PCI FLR the MSI-X Enable flag in the VF PCI MSI-X capability
> register will be cleared. This can lead to issues when a VF is
> assigned to a VM because in these cases the VF driver receives no
> indication of the PF PCI error/reset and additionally it is incapable
> of restoring the cleared flag in the hypervisor configuration space
> without fully reinitializing the driver interrupt functionality.
>
> Since the VF driver is unable to easily resolve this condition on its own,
> restore the VF MSI-X flag during the PF PCI reset handling.
>
> Fixes: 19b7960b2da1 ("i40e: implement split PCI error reset handler")
> Co-developed-by: Karen Ostrowska <karen.ostrowska@intel.com>
> Signed-off-by: Karen Ostrowska <karen.ostrowska@intel.com>
> Co-developed-by: Mateusz Palczewski <mateusz.palczewski@intel.com>
> Signed-off-by: Mateusz Palczewski <mateusz.palczewski@intel.com> > Reviewed-by: Drewek Wojciech <wojciech.drewek@intel.com>
It's good that you pass tags from our e1000 ML here,
however please copy them verbatim from the response body (instead of
copying that from whatever MS outlook displays as sender).
(Wojtek's RB was fine in previous version of the patch)
> Reviewed-by: Kitszel Przemyslaw <przemyslaw.kitszel@intel.com>
You should never add such tags when not explicitly provided by reviewer.
> Signed-off-by: Andrii Staikov <andrii.staikov@intel.com>
> ---
> v1 -> v2: Fix signed-off tags
> v2 -> v3: use @vf_dev in pci_get_device() instead of NULL and
> remove unnecessary call
Thank you, code looks fine now.
> ---
> drivers/net/ethernet/intel/i40e/i40e_main.c | 2 ++
> .../ethernet/intel/i40e/i40e_virtchnl_pf.c | 24 +++++++++++++++++++
> .../ethernet/intel/i40e/i40e_virtchnl_pf.h | 1 +
> 3 files changed, 27 insertions(+)
Assuming you will fix RB tags:
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-12-07 9:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 12:51 [Intel-wired-lan] [PATCH iwl-net v3] i40e: Restore VF MSI-X state during PCI reset Andrii Staikov
2023-12-07 9:34 ` Przemek Kitszel [this message]
2023-12-07 20:33 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9745f1f1-b93c-3df5-e235-db2b256d610b@intel.com \
--to=przemyslaw.kitszel@intel.com \
--cc=andrii.staikov@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=karen.ostrowska@intel.com \
--cc=mateusz.palczewski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox