From: "Neftin, Sasha" <sasha.neftin@intel.com>
To: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>,
<intel-wired-lan@osuosl.org>
Cc: anthony.l.nguyen@intel.com
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v2] igc: Remove delay during TX ring configuration
Date: Wed, 17 May 2023 10:12:42 +0300 [thread overview]
Message-ID: <992bd3bd-1ccf-9866-6a36-0bef74c5673c@intel.com> (raw)
In-Reply-To: <20230517001812.8101-1-muhammad.husaini.zulkifli@intel.com>
On 5/17/2023 03:18, Muhammad Husaini Zulkifli wrote:
> Remove unnecessary delay during the TX ring configuration.
> This will cause delay, especially during link down and
> link up activity.
>
> Furthermore, old SKUs like as I225 will call the reset_adapter
> to reset the controller during TSN mode Gate Control List (GCL)
> setting. This will add more time to the configuration of the
> real-time use case.
>
> It doesn't mentioned about this delay in the Software User Manual.
> It might have been ported from legacy code I210 in the past.
>
> Fixes: 13b5b7fd6a4a ("igc: Add support for Tx/Rx rings")
> Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
>
> ---
> V1 -> V2: Update commit message.
> ---
> ---
> drivers/net/ethernet/intel/igc/igc_main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
> index d1e8a5eee811b..a65ddddcda5d0 100644
> --- a/drivers/net/ethernet/intel/igc/igc_main.c
> +++ b/drivers/net/ethernet/intel/igc/igc_main.c
> @@ -711,7 +711,6 @@ static void igc_configure_tx_ring(struct igc_adapter *adapter,
> /* disable the queue */
> wr32(IGC_TXDCTL(reg_idx), 0);
> wrfl();
> - mdelay(10);
>
> wr32(IGC_TDLEN(reg_idx),
> ring->count * sizeof(union igc_adv_tx_desc));
Acked-by: Sasha Neftin <sasha.neftin@intel.com>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-05-17 7:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 0:18 [Intel-wired-lan] [PATCH iwl-net v2] igc: Remove delay during TX ring configuration Muhammad Husaini Zulkifli
2023-05-17 7:12 ` Neftin, Sasha [this message]
2023-06-05 8:10 ` naamax.meir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=992bd3bd-1ccf-9866-6a36-0bef74c5673c@intel.com \
--to=sasha.neftin@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@osuosl.org \
--cc=muhammad.husaini.zulkifli@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox