From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brandeburg, Jesse Date: Sat, 16 Nov 2019 02:43:18 +0000 Subject: [Intel-wired-lan] [PATCH] i40e: Fix virtchnl_queue_select bitmap validation In-Reply-To: <897250446bee4cdc987a9478db97873a@intel.com> References: <20191113192817.531297-1-jeffrey.t.kirsher@intel.com> <309B89C4C689E141A5FF6A0C5FB2118B971758C2@ORSMSX103.amr.corp.intel.com>, <897250446bee4cdc987a9478db97873a@intel.com> Message-ID: <9C221CD4-702F-4A6F-8475-2A67012ADD10@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: Brett is out on vacation but you?re right Andrew, the code should use plural variables. -- Jesse Brandeburg > On Nov 15, 2019, at 16:08, Bowers, AndrewX wrote: > > I was getting the same thing. Taking the compiler's suggestion and changing _queue to _queues and it compiles but nobody responded to my comments. > >> -----Original Message----- >> From: Brown, Aaron F >> Sent: Friday, November 15, 2019 3:53 PM >> To: Bowers, AndrewX ; Kirsher, Jeffrey T >> ; intel-wired-lan at lists.osuosl.org >> Cc: Creeley, Brett ; Arkady Gilinksky >> >> Subject: RE: [Intel-wired-lan] [PATCH] i40e: Fix virtchnl_queue_select bitmap >> validation >> >> This patch is causing a compile error for me. If I pop revert it my compile >> error goes away: >> --------------------------------------------------------------- >> drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c: In function >> 'i40e_vc_validate_vqs_bitmaps': >> drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c:2333:9: error: 'struct >> virtchnl_queue_select' has no member named 'rx_queue' >> vqs->rx_queue >= BIT(I40E_MAX_VF_QUEUES) || >> ^ >> drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c:2334:9: error: 'struct >> virtchnl_queue_select' has no member named 'tx_queue' >> vqs->tx_queue >= BIT(I40E_MAX_VF_QUEUES)) >> ^ >> make[6]: *** [drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.o] Error 1 >> make[6]: *** Waiting for unfinished jobs.... >> make[5]: *** [drivers/net/ethernet/intel/i40e] Error 2 >> make[4]: *** [drivers/net/ethernet/intel] Error 2 >> make[4]: *** Waiting for unfinished jobs.... >> make[3]: *** [drivers/net/ethernet] Error 2 >> make[2]: *** [drivers/net] Error 2 >> make[1]: *** [drivers] Error 2 >> make: *** [sub-make] Error 2 >> >>> -----Original Message----- >>> From: Intel-wired-lan On Behalf >>> Of Bowers, AndrewX >>> Sent: Thursday, November 14, 2019 5:17 PM >>> To: Kirsher, Jeffrey T ; intel-wired- >>> lan at lists.osuosl.org >>> Cc: Creeley, Brett ; Arkady Gilinksky >>> >>> Subject: Re: [Intel-wired-lan] [PATCH] i40e: Fix virtchnl_queue_select >>> bitmap validation >>> >>> Comments inline >>> >>>> -----Original Message----- >>>> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On >>>> Behalf Of Jeff Kirsher >>>> Sent: Wednesday, November 13, 2019 11:28 AM >>>> To: intel-wired-lan at lists.osuosl.org >>>> Cc: Creeley, Brett ; Arkady Gilinksky >>>> >>>> Subject: [Intel-wired-lan] [PATCH] i40e: Fix virtchnl_queue_select >>>> bitmap validation >>>> >>>> From: Brett Creeley >>>> >>>> Currently in i40e_vc_disable_queues_msg() we are incorrectly >>>> validating >>> the >>>> virtchnl queue select bitmaps. The virtchnl_queue_select rx_queues >>>> and tx_queue bitmap is being compared against ICE_MAX_VF_QUEUES, >> but >>> the >>>> problem is that these bitmaps can have a value greater than >>>> I40E_MAX_VF_QUEUES. >>>> Fix this by comparing the bitmaps against BIT(I40E_MAX_VF_QUEUES). >>>> >>>> Also, add the function i40e_vc_validate_vqs_bitmaps() that checks to >>>> see if both virtchnl_queue_select bitmaps are empty along with >>>> checking that >>> the >>>> bitmaps only have valid bits set. This function can then be used in >>>> both the queue enable and disable flows. >>>> >>>> Suggested-by: Arkady Gilinksky >>>> Signed-off-by: Brett Creeley >>>> --- >>>> .../ethernet/intel/i40e/i40e_virtchnl_pf.c | 22 +++++++++++++++---- >>>> 1 file changed, 18 insertions(+), 4 deletions(-) >>>> >> > _______________________________________________ > Intel-wired-lan mailing list > Intel-wired-lan at osuosl.org > https://lists.osuosl.org/mailman/listinfo/intel-wired-lan