From: Nguyen, Anthony L <anthony.l.nguyen@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net v1] i40e: Fix for failed to init adminq while VF reset and for sync VF driver reset
Date: Wed, 9 Jun 2021 18:23:29 +0000 [thread overview]
Message-ID: <9afe652dbf360187d1a6c498cbe3291aeeabe0ab.camel@intel.com> (raw)
In-Reply-To: <20210609105101.88005-1-karen.sornek@intel.com>
On Wed, 2021-06-09 at 12:51 +0200, Karen Sornek wrote:
> Fix for failed to init adminq: -53 while VF is resetting via MAC
> address changing procedure.
> Added sync module to avoid reading deadbeef value in reinit adminq
> during software reset.
> Fix for sync VF driver reset before trigger next one by PF.
> Change VF in reset state detection from check VFR state
> register to examination of enable admin queue interrupt.
> ADMINQ is enabled by VF after completely reinit admin queue.
>
> Fixes: b40c82e6ae85 ("i40e: Fix inconsistent use of PF/VF vs pf/vf")
> Signed-off-by: Grzegorz Szczurek <grzegorzx.szczurek@intel.com>
> Signed-off-by: Karen Sornek <karen.sornek@intel.com>
> ---
> .../net/ethernet/intel/i40e/i40e_register.h | 10 +++++
> .../ethernet/intel/i40e/i40e_virtchnl_pf.c | 45
> ++++++++++++++++++-
> .../ethernet/intel/i40e/i40e_virtchnl_pf.h | 1 +
> 3 files changed, 54 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_register.h
> b/drivers/net/ethernet/intel/i40e/i40e_register.h
> index 8d0588a27..b5c741e76 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_register.h
> +++ b/drivers/net/ethernet/intel/i40e/i40e_register.h
> @@ -371,6 +371,16 @@
> #define I40E_PFINT_ICR0_ENA_VFLR_MASK I40E_MASK(0x1,
> I40E_PFINT_ICR0_ENA_VFLR_SHIFT)
> #define I40E_PFINT_ICR0_ENA_ADMINQ_SHIFT 30
> #define I40E_PFINT_ICR0_ENA_ADMINQ_MASK I40E_MASK(0x1,
> I40E_PFINT_ICR0_ENA_ADMINQ_SHIFT)
> +#define I40E_VFINT_ICR0_ADMINQ_SHIFT 30
> +#define I40E_VFINT_ICR0_ADMINQ_MASK I40E_MASK(0x1,
> I40E_VFINT_ICR0_ADMINQ_SHIFT)
> +#define I40E_VFINT_ICR0_ENA(_VF) (0x0002C000 + ((_VF) * 4)) /*
> _i=0...127 */ /* Reset: CORER */
> +#define I40E_VFINT_ICR0_ENA_MAX_INDEX 127
> +#define I40E_VFINT_ICR0_ENA_LINK_STAT_CHANGE_SHIFT 25
> +#define I40E_VFINT_ICR0_ENA_LINK_STAT_CHANGE_MASK I40E_MASK(0x1,
> I40E_VFINT_ICR0_ENA_LINK_STAT_CHANGE_SHIFT)
> +#define I40E_VFINT_ICR0_ENA_ADMINQ_SHIFT 30
> +#define I40E_VFINT_ICR0_ENA_ADMINQ_MASK I40E_MASK(0x1,
> I40E_VFINT_ICR0_ENA_ADMINQ_SHIFT)
> +#define I40E_VFINT_ICR0_ENA_RSVD_SHIFT 31
> +#define I40E_VFINT_ICR0_ENA_RSVD_MASK I40E_MASK(0x1,
> I40E_VFINT_ICR0_ENA_RSVD_SHIFT)
I don't see that all the new defines are being used. Can you remove the
unused ones?
prev parent reply other threads:[~2021-06-09 18:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 10:51 [Intel-wired-lan] [PATCH net v1] i40e: Fix for failed to init adminq while VF reset and for sync VF driver reset Karen Sornek
2021-06-09 18:23 ` Nguyen, Anthony L [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9afe652dbf360187d1a6c498cbe3291aeeabe0ab.camel@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox