Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Anatolii Gerasymenko <anatolii.gerasymenko@intel.com>,
	<intel-wired-lan@lists.osuosl.org>
Cc: Benjamin Mikailenko <benjamin.mikailenko@intel.com>,
	Jesse Brandeburg <jesse.brandeburg@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH net-next v3 1/2] ice: Implement control of FCS/CRC stripping
Date: Tue, 26 Jul 2022 14:40:22 -0700	[thread overview]
Message-ID: <9b99fe2a-c4e8-6e4d-cf9c-4d28796ed9bf@intel.com> (raw)
In-Reply-To: <20220725070210.488309-2-anatolii.gerasymenko@intel.com>



On 7/25/2022 12:02 AM, Anatolii Gerasymenko wrote:
> From: Jesse Brandeburg <jesse.brandeburg@intel.com>
> 
> The driver can allow the user to configure whether the CRC aka the FCS
> (Frame Check Sequence) is DMA'd to the host as part of the receive
> buffer.  The driver usually wants this feature disabled so that the
> hardware checks the FCS and strips it in order to save PCI bandwidth.
> 
> Control the reception of FCS to the host using the command:
> ethtool -K eth0 rx-fcs <on|off>
> 
> The default shown in ethtool -k eth0 | grep fcs; should be "off", as the
> hardware will drop any frame with a bad checksum, and DMA of the
> checksum is useless overhead especially for small packets.
> 
> Testing Hints:
> test the FCS/CRC arrives with received packets using
> tcpdump -nnpi eth0 -xxxx
> and it should show crc data as the last 4 bytes of the packet. Can also
> use wireshark to turn on CRC checking and check the data is correct.
> 
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Co-Developed-by: Grzegorz Nitka <grzegorz.nitka@intel.com>
> Signed-off-by: Grzegorz Nitka <grzegorz.nitka@intel.com>
> Co-Developed-by: Benjamin Mikailenko <benjamin.mikailenko@intel.com>
> Signed-off-by: Benjamin Mikailenko <benjamin.mikailenko@intel.com>
> Co-Developed-by: Anatolii Gerasymenko <anatolii.gerasymenko@intel.com>
> Signed-off-by: Anatolii Gerasymenko <anatolii.gerasymenko@intel.com>

WARNING: 'Co-developed-by:' is the preferred signature form
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

  reply	other threads:[~2022-07-26 21:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-25  7:02 [Intel-wired-lan] [PATCH net-next v3 0/2] ice: FCS/CRC stripping control Anatolii Gerasymenko
2022-07-25  7:02 ` [Intel-wired-lan] [PATCH net-next v3 1/2] ice: Implement control of FCS/CRC stripping Anatolii Gerasymenko
2022-07-26 21:40   ` Tony Nguyen [this message]
2022-07-27  7:26     ` Anatolii Gerasymenko
2022-07-25  7:02 ` [Intel-wired-lan] [PATCH net-next v3 2/2] ice: Implement FCS/CRC and VLAN stripping co-existence policy Anatolii Gerasymenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9b99fe2a-c4e8-6e4d-cf9c-4d28796ed9bf@intel.com \
    --to=anthony.l.nguyen@intel.com \
    --cc=anatolii.gerasymenko@intel.com \
    --cc=benjamin.mikailenko@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jesse.brandeburg@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox