From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F36AC54EBC for ; Thu, 12 Jan 2023 09:54:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id E73B9400D6; Thu, 12 Jan 2023 09:54:00 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org E73B9400D6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1673517240; bh=5kufTGTtHBHWz5BpHvWCkelCdmdmfyF1GpZEcavT2WM=; h=Date:To:References:From:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=TvSv3MFIuIXCyI0nu9RVEnnM6UQLtgxDQJFeDTqUBBYzljZ8LYp2Z2hQ04jigIPOr 8AEnD5NTSFwlFNegRGzObZkQ4EIpBsYTMoqtSm16d49pfPFCmcLvab7IfgZtT3zF1t 8YrCvROM6ybTnl/U2SIpoWu0J3QuDlDXZO0ePv4aYFY21jFBzePdWb+feYvcAzKDsR JKiZsFMuDkMThSD4kp3ShfZ+C339PQ5rPdIkspzt5qIPrx5/29xy8//P4YtRg/X3Q1 higP34o44Gy/PmsdSBIY4DwBQdg5c8wdpI/6s7Zeg+IrcHZw/pTl8IuH33XnPqIVm3 EVUOlNOY3lJhA== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ly_IJKNzqAKJ; Thu, 12 Jan 2023 09:54:00 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id ECCAC401E1; Thu, 12 Jan 2023 09:53:59 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org ECCAC401E1 Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 8AD541BF3DB for ; Thu, 12 Jan 2023 09:53:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 60CAB401E1 for ; Thu, 12 Jan 2023 09:53:58 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 60CAB401E1 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id swLNoKVlPJQZ for ; Thu, 12 Jan 2023 09:53:57 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 2FC5B400D6 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by smtp2.osuosl.org (Postfix) with ESMTPS id 2FC5B400D6 for ; Thu, 12 Jan 2023 09:53:57 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="322362342" X-IronPort-AV: E=Sophos;i="5.96,319,1665471600"; d="scan'208";a="322362342" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2023 01:53:56 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="688282285" X-IronPort-AV: E=Sophos;i="5.96,319,1665471600"; d="scan'208";a="688282285" Received: from naamamex-mobl.ger.corp.intel.com (HELO [10.13.13.104]) ([10.13.13.104]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2023 01:53:55 -0800 Message-ID: <9ce9b3fe-61a6-05fa-c842-f7b2e37008cb@linux.intel.com> Date: Thu, 12 Jan 2023 11:53:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 To: Sasha Neftin , intel-wired-lan@lists.osuosl.org References: <20230110054841.1857688-1-sasha.neftin@intel.com> Content-Language: en-US From: "naamax.meir" In-Reply-To: <20230110054841.1857688-1-sasha.neftin@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673517237; x=1705053237; h=message-id:date:mime-version:subject:to:references:from: in-reply-to:content-transfer-encoding; bh=up/zv5xEUZ/xsXuAErr8bT49EY3EunHSrrCg8QSD8ik=; b=fbq42jM4yQMBMtqiAdYLSCD1A0jPgg5W7k2iTZXaCwL/LTQhd9qzPp5t FA6zdOHR9x6tpWRjXwO9Iep52NaJPrUFhoerU2vNOXmwq8O4pIpMJKC29 0sCKZfU/DEec1Urkpukm3Qfq6A5UZK8F+muenOIgTZKvBY6JKoK0+WvRW PWG7zHEQz5KJorVtk9iSIJncngYraW2Qk4qOlBtIGWacDfns6YCgGdHSZ RrsK68o/A6gkqZPiltnWbEGtaiKsLVvNiKESjU9mQy0SxGIE6Peqh37w6 X1C0f3glu/5jVd1yzVxXJxdNt+alH2BVJaxxPreougvL0kLbyBDXxs890 Q==; X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=fbq42jM4 Subject: Re: [Intel-wired-lan] [PATCH net v1 1/1] igc: Add ndo_tx_timeout support X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On 1/10/2023 07:48, Sasha Neftin wrote: > On some platforms, 100/1000/2500 speeds seem to have sometimes problems > reporting false positive tx unit hang during stressful UDP traffic. Likely > other Intel drivers introduce responses to a tx hang. Update the 'tx hang' > comparator with the comparison of the head and tail of ring pointers and > restore the tx_timeout_factor to the previous value (one). > > This can be test by using netperf or iperf3 applications. > Example: > iperf3 -s -p 5001 > iperf3 -c 192.168.0.2 --udp -p 5001 --time 600 -b 0 > > netserver -p 16604 > netperf -H 192.168.0.2 -l 600 -p 16604 -t UDP_STREAM -- -m 64000 > > Fixes: b27b8dc77b5e ("igc: Increase timeout value for Speed 100/1000/2500") > Signed-off-by: Sasha Neftin > --- > drivers/net/ethernet/intel/igc/igc_main.c | 25 +++++++++++++++++++++-- > 1 file changed, 23 insertions(+), 2 deletions(-) Tested-by: Naama Meir _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan