From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: "Wilczynski, Michal" <michal.wilczynski@intel.com>,
<intel-wired-lan@lists.osuosl.org>
Cc: Raj Victor <victor.raj@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH net-next v2 1/2] ice: Code added to support 5 layer topology
Date: Wed, 29 Jun 2022 08:57:25 -0700 [thread overview]
Message-ID: <9d3fb37f-036e-283e-05fe-c0a4417a3991@intel.com> (raw)
In-Reply-To: <c2a2284d-4616-6b76-57c9-2d34b800b38f@intel.com>
On 6/29/2022 1:54 AM, Wilczynski, Michal wrote:
> Hi, thanks for your review
>
> On 6/29/2022 12:21 AM, Tony Nguyen wrote:
>>
>>
>> On 6/24/2022 3:21 AM, Michal Wilczynski wrote:
>>> +struct ice_aqc_get_set_tx_topo {
>>> + u8 set_flags;
>>> +#define ICE_AQC_TX_TOPO_FLAGS_CORRER BIT(0)
>>> +#define ICE_AQC_TX_TOPO_FLAGS_SRC_RAM BIT(1)
>>> +#define ICE_AQC_TX_TOPO_FLAGS_SET_PSM BIT(2)
>>> +#define ICE_AQC_TX_TOPO_FLAGS_LOAD_NEW BIT(4)
>>> +#define ICE_AQC_TX_TOPO_FLAGS_ISSUED BIT(5)
>>
>> Not all the defines are being used, please remove the unused ones.
>> Also, please add newline between the member & related defines from the
>> next to make the associations a little more distinct.
>
>
> Hi, good point with the unused ones, but the newline idea doesn't seem
> to follow the convention used in the file.
This was a more recent comment/change due to maintainer feedback [1].
Though we haven't changed existing usages, new ones should comply to it.
The other option is to pull it out of the structure completely.
https://lore.kernel.org/netdev/1f87f6c4173c239d2c082500509736cf5f18357d.camel@intel.com/
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2022-06-29 15:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 10:21 [Intel-wired-lan] [PATCH net-next v2 0/2] ice: Support 5 layer tx scheduler topology Michal Wilczynski
2022-06-24 10:21 ` [Intel-wired-lan] [PATCH net-next v2 1/2] ice: Code added to support 5 layer topology Michal Wilczynski
2022-06-28 22:21 ` Tony Nguyen
2022-06-29 8:54 ` Wilczynski, Michal
2022-06-29 15:57 ` Tony Nguyen [this message]
2022-06-29 10:49 ` Paul Menzel
2022-07-01 13:22 ` Wilczynski, Michal
2022-06-24 10:21 ` [Intel-wired-lan] [PATCH net-next v2 2/2] ice: Enable switching default tx scheduler topology Michal Wilczynski
2022-06-25 7:10 ` Paul Menzel
2022-06-29 9:54 ` Wilczynski, Michal
2022-07-01 13:12 ` Wilczynski, Michal
2022-06-28 22:27 ` Tony Nguyen
2022-07-01 15:19 ` Wilczynski, Michal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d3fb37f-036e-283e-05fe-c0a4417a3991@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=michal.wilczynski@intel.com \
--cc=victor.raj@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox